Re: Patch for 5310

2008-10-28 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > In next cleanup round, I would like that many functions in lyxfind.cpp > to only work with DocIterators so that we are not forced to use a > BufferView. And I think it would be nice to have a dociterator with a buffer attached to it (but no buffervie

Re: Patch for 5310

2008-10-24 Thread Abdelrazak Younes
On 24/10/2008 17:50, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: After thinking more about it and trying it out I think now it is the right solution. This code was needed when we were iterating with the full cursor (not the top slice). Alfredo missed this when h

Re: Patch for 5310

2008-10-24 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> After thinking more about it and trying it out I think now it is the >> right solution. This code was needed when we were iterating with the >> full cursor (not the top slice). Alfredo missed this when he rewrite the >> code last year. >> > ACK.

Re: Patch for 5310

2008-10-24 Thread Jean-Marc Lasgouttes
José Matos <[EMAIL PROTECTED]> writes: > On Friday 24 October 2008 16:29:22 Jean-Marc Lasgouttes wrote: >> Jose'? > > OK. Applied. JMarc

Re: Patch for 5310

2008-10-24 Thread Abdelrazak Younes
On 24/10/2008 17:29, Jean-Marc Lasgouttes wrote: Jean-Marc Lasgouttes<[EMAIL PROTECTED]> writes: Then a more annoying problem occurs: in findnextChange, we have the code // avoid crash (assertion violation) if the imaginary end-of-par // character of the last paragraph of

Re: Patch for 5310 (was: Re: [PATCH] show changes when merging and another change tracking bug)

2008-10-24 Thread José Matos
On Friday 24 October 2008 16:29:22 Jean-Marc Lasgouttes wrote: > Jose'? OK. > JMarc -- José Abílio