Re: Patch: Diagram inset

2010-09-20 Thread Uwe Stöhr
Am 20.09.2010 05:24, schrieb Ronen Abravanel: Sorry, this file contains the feynman-doc. Thanks for this contribution. I need to create a separate file with your examples because otherwise the Math manual would not be compilable if the package feyn is not installed. This is because feyn is a

Re: Patch: Diagram inset

2010-09-20 Thread Uwe Stöhr
Am 20.09.2010 20:04, schrieb Ronen Abravanel: The latex error is "Improper alphabetic content" , [64] [65] [66] [67] [68] (./Math.ind [69] ! Improper alphabetic constant. \tmspace l.10 \item Accents\char `\tmspace -\thinmuskip {.1667em}for one character, A one-character control sequence bel

Re: Patch: Diagram inset

2010-09-20 Thread Pavel Sanda
Uwe Stöhr wrote: > As you know an undocumented feature won't be used - that's why we have e.g. > the Math manual. There already exists in sec. 21 "Diagrams" a description > of amscd and a link to the xymatrix description. Can you do me a favor and > write either just thinking loudly... we dont

Re: Patch: Diagram inset

2010-09-20 Thread Pavel Sanda
Uwe Stöhr wrote: > You will see that LyX 1.6.x cannot handle the columns, because it is > unknown for it that \Diagram can have columns and rows. aha, that explain the strange eoln i have seen in diffs between 2.0 and 1.6. pavel

Re: Patch: Diagram inset

2010-09-20 Thread Pavel Sanda
Uwe Stöhr wrote: > - something similar as I did for amscd in the Math manual > or > - a separate file like our XYmatrix manual (if a description would be too > big for the Math manual) at the very begining of the thread there was example file with lot of stuff which can not be simply add to the m

Re: Patch: Diagram inset

2010-09-20 Thread Uwe Stöhr
Am 20.09.2010 05:24, schrieb Ronen Abravanel: The latex error is "Improper alphabetic content" , [64] [65] [66] [67] [68] (./Math.ind [69] ! Improper alphabetic constant. \tmspace l.10 \item Accents\char `\tmspace -\thinmuskip {.1667em}for one character, A one-character control sequence belong

Re: Patch: Diagram inset

2010-09-19 Thread Uwe Stöhr
Am 20.09.2010 04:52, schrieb Ronen Abravanel: Added few paragraphs to the Math manual (the full manual attached. note that the file version changed to 401). Your attached file doesn't contain any feyn-related stuff and is in format 345. regards Uwe

Re: Patch: Diagram inset

2010-09-19 Thread Uwe Stöhr
Am 20.09.2010 04:52, schrieb Ronen Abravanel: Added few paragraphs to the Math manual (the full manual attached. note that the file version changed to 401). It won't compile for me even before the change, so I'll appreciate if someone will make sure it's compiles properly. What errors do you g

Re: Patch: Diagram inset

2010-09-19 Thread Uwe Stöhr
Am 20.09.2010 03:54, schrieb Richard Heck: Take your example file and export it to LyX 1.6.x format. Then open this with LyX 1.6.7 and you can see that the PDF output is completely different from that in LyX 2.0. can you please have a look? What is the difference between the LaTeX that is ou

Re: Patch: Diagram inset

2010-09-19 Thread Richard Heck
While playing with your feature i noticed that the export to the LyX 1.6 fileformat via lyx2lyx is not working. I now fixed the bug that the LyX 1.6.x files were not compilable. But there are still some issues: Take your example file and export it to LyX 1.6.x format. Then open this with LyX 1

Re: Patch: Diagram inset

2010-09-19 Thread Uwe Stöhr
Hello Ronen, thanks for your cool new feature! As you know an undocumented feature won't be used - that's why we have e.g. the Math manual. There already exists in sec. 21 "Diagrams" a description of amscd and a link to the xymatrix description. Can you do me a favor and write either - someth

Re: Patch: Diagram inset

2010-09-19 Thread Ronen Abravanel
I'll need a password for the wiki.. Thanks, Ronen. On Sun, Sep 19, 2010 at 6:46 PM, Pavel Sanda wrote: > Pavel Sanda wrote: > > Ronen Abravanel wrote: > > > > > (The only part changes now: The comment in Buffer.cpp) > > everything is in now. > most probably you want to put some bullet into late

Re: Patch: Diagram inset

2010-09-19 Thread Pavel Sanda
Pavel Sanda wrote: > Ronen Abravanel wrote: > > > (The only part changes now: The comment in Buffer.cpp) everything is in now. most probably you want to put some bullet into latex section of newinlyx20 wiki. > also post the example file... >pave

Re: Patch: Diagram inset

2010-09-19 Thread Pavel Sanda
Ronen Abravanel wrote: > (The only part changes now: The comment in Buffer.cpp) i'll wait day more if somebody else has comments and then commit. also post the example file... good work, pavel

Re: Patch: Diagram inset

2010-09-19 Thread Ronen Abravanel
On Sun, Sep 19, 2010 at 11:46 AM, Richard Heck wrote: > On 9/19/10 11:19 AM, Ronen Abravanel wrote: > >> >> +def revert_diagram(document): >> + i = 0 >> + re_diagram = re.compile(r'\\begin_inset Formula .*\\Diagram', >> re.DOTALL) >> + while True: >> +i = find_token(document.body, '\\begin

Re: Patch: Diagram inset

2010-09-19 Thread Richard Heck
On 9/19/10 11:19 AM, Ronen Abravanel wrote: +def revert_diagram(document): + i = 0 + re_diagram = re.compile(r'\\begin_inset Formula .*\\Diagram', re.DOTALL) + while True: +i = find_token(document.body, '\\begin_inset Formula', i) +if i == -1: + return +j = find_end_of_inset(

Re: Patch: Diagram inset

2010-09-19 Thread Ronen Abravanel
On Sun, Sep 19, 2010 at 3:35 AM, Pavel Sanda wrote: > Ronen Abravanel wrote: > > Pavel -- Thanks. I removed big portion of the code that was not needed. > > good news > > > I can refactor both XYMatrix and Diagram class to have one common base > > class, but it will take me a while. How urgent th

Re: Patch: Diagram inset

2010-09-19 Thread Pavel Sanda
Ronen Abravanel wrote: > Pavel -- Thanks. I removed big portion of the code that was not needed. good news > I can refactor both XYMatrix and Diagram class to have one common base > class, but it will take me a while. How urgent things should be ready for > 2.0? personally i would prefer not to

Re: Patch: Diagram inset

2010-09-18 Thread Ronen Abravanel
Thanks, Richard -- The python code you sent me did not done the job. I fixed it. Pavel -- Thanks. I removed big portion of the code that was not needed. But now, both classes are little more different. I can refactor both XYMatrix and Diagram class to have one common base class, but it will take

Re: Patch: Diagram inset

2010-09-18 Thread Richard Heck
On 09/18/2010 04:48 PM, Pavel Sanda wrote: also this is fileformat change - that is .lyx files generated with this patch cannot be correctly read by older version of lyx and we need to handle that. it should be simple here - either only bump file version or we just need that when file is conver

Re: Patch: Diagram inset

2010-09-18 Thread Pavel Sanda
Ronen Abravanel wrote: > Hello, > > I created a patch that adds a Feynman diagram inset into lyx. The inset is > based on the inst "Diagram" in the package feyn ( > http://www.ctan.org/tex-archive/fonts/feyn/ ) . The inset is meant to > replace the hack described in the 3rd section of the followin