Re: Next Counters patch.

2002-09-10 Thread Andre Poenitz
On Fri, Sep 06, 2002 at 01:22:04PM +0100, Angus Leeming wrote: > It says that we set this once and once only in the c-tor "preamble" (whatever > that : part outside the c-tor body is really called). initializer list Andre' -- Those who desire to give up Freedom in order to gain Security, will

Re: Next Counters patch.

2002-09-06 Thread Martin Vermeer
On Fri, Sep 06, 2002 at 02:03:38PM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | Try this: > | > | 1) Load a document, any document, as long as it contains chapter headers. > | 2) Close the doc. Do NOT exit LyX. > | 3) Open the same doc again. > > Ok, t

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Friday 06 September 2002 1:43 pm, Lars Gullik Bjønnes wrote: | | > | | A minor point. Shouldn't this be | > | | + boost::shared_ptr const ctrs_; | > | | | > | | showing future maintainers that you're using the shared_ptr only to | > | | avoid

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Friday 06 September 2002 1:35 pm, Lars Gullik Bjønnes wrote: | > Angus Leeming <[EMAIL PROTECTED]> writes: | > | On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: | > | > Ok, the following update seems to fix that problem. | > | > If yo

Re: Next Counters patch.

2002-09-06 Thread Angus Leeming
On Friday 06 September 2002 1:43 pm, Lars Gullik Bjønnes wrote: > | | A minor point. Shouldn't this be > | | + boost::shared_ptr const ctrs_; > | | > | | showing future maintainers that you're using the shared_ptr only to > | | avoid including counter.h in lyxtextclass.h. > | > | Perhaps... but h

Re: Next Counters patch.

2002-09-06 Thread Angus Leeming
On Friday 06 September 2002 1:35 pm, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > | On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: > | > Ok, the following update seems to fix that problem. > | > If you have time, please look at it again. > | > | @@ -191

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Fri, Sep 06, 2002 at 02:37:25PM +0200, Lars Gullik Bjønnes wrote: | | > Angus Leeming <[EMAIL PROTECTED]> writes: | > | > | On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: | > | > | Try this: | > | > | | > | > | 1) Load a document

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Angus Leeming <[EMAIL PROTECTED]> writes: | | | On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: | | | | > Ok, the following update seems to fix that problem. | | > If you have time, please look at it again. | | | | @@ -191,6 +19

Re: Next Counters patch.

2002-09-06 Thread Martin Vermeer
On Fri, Sep 06, 2002 at 02:37:25PM +0200, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: > | > | Try this: > | > | > | > | 1) Load a document, any document, as long as it contains chapter headers. > |

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: | > | Try this: | > | | > | 1) Load a document, any document, as long as it contains chapter headers. | > | 2) Close the doc. Do NOT exit LyX. | > | 3) Open the same doc again. | > | > Ok,

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: | | > Ok, the following update seems to fix that problem. | > If you have time, please look at it again. | | @@ -191,6 +197,9 @@ private: | | /// | FloatList floatlist_; | +

Re: Next Counters patch.

2002-09-06 Thread Angus Leeming
On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: > | Try this: > | > | 1) Load a document, any document, as long as it contains chapter headers. > | 2) Close the doc. Do NOT exit LyX. > | 3) Open the same doc again. > > Ok, the following update seems to fix that problem. > If you ha

Re: Next Counters patch.

2002-09-06 Thread Angus Leeming
On Friday 06 September 2002 1:03 pm, Lars Gullik Bjønnes wrote: > Ok, the following update seems to fix that problem. > If you have time, please look at it again. @@ -191,6 +197,9 @@ private: /// FloatList floatlist_; + + /// + boost::shared_ptr ctrs_; A minor point

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | Try this: | | 1) Load a document, any document, as long as it contains chapter headers. | 2) Close the doc. Do NOT exit LyX. | 3) Open the same doc again. Ok, the following update seems to fix that problem. If you have time, please look at it again.

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Fri, Sep 06, 2002 at 10:04:11AM +0200, Lars Gullik Bjønnes wrote: | | > Martin Vermeer <[EMAIL PROTECTED]> writes: | | > | As this is now .layout-driven, if it works with figure and table, no | > | need to test separately for user defined floats.

Re: Next Counters patch.

2002-09-06 Thread Martin Vermeer
On Fri, Sep 06, 2002 at 10:04:11AM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > | As this is now .layout-driven, if it works with figure and table, no > | need to test separately for user defined floats... test especially the > | trouble spots, like re-count

Re: Next Counters patch.

2002-09-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Fri, Sep 06, 2002 at 12:53:32AM +0200, Lars Gullik Bjønnes wrote: | | > | > This patch moves the counters out into the layout files, but not yet | > in the nice way. This does also not reduce much of the hardcoding on | > enum names in the source

Re: Next Counters patch.

2002-09-05 Thread Martin Vermeer
On Fri, Sep 06, 2002 at 12:53:32AM +0200, Lars Gullik Bjønnes wrote: > > This patch moves the counters out into the layout files, but not yet > in the nice way. This does also not reduce much of the hardcoding on > enum names in the source. What about giving the layout file entry for that cou