Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> On Tue, Feb 28, 2006 at 07:43:23PM +0100, Georg Baum wrote:
> > Am Dienstag, 28. Februar 2006 18:44 schrieb Martin Vermeer:
> >
> > > OK if I commit this? It's your fix as much as mine
> >
> > Yes, of course.
>
> Done.
>
> - Martin
>
Not sure
Martin Vermeer <[EMAIL PROTECTED]> writes:
| On Tue, Feb 28, 2006 at 07:43:23PM +0100, Georg Baum wrote:
| > Am Dienstag, 28. Februar 2006 18:44 schrieb Martin Vermeer:
| >
| > > OK if I commit this? It's your fix as much as mine
| >
| > Yes, of course.
|
| Done.
Good. I will create the branch
On Tue, Feb 28, 2006 at 10:55:14AM +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> >> If we can get some more people to test this and also test other
> >> operations to try to make sure that no regressions are introcuced,
> >> then if all agree
On Mon, Feb 27, 2006 at 10:07:44AM +0100, Jean-Marc Lasgouttes wrote:
> > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> >> you mean \mathbb{R}, then select and C-M? Typing \mathbbR
> >> gives the expected result to me.
>
> Andre> That this space is rquired is also a regression and
On Tue, Feb 28, 2006 at 07:43:23PM +0100, Georg Baum wrote:
> Am Dienstag, 28. Februar 2006 18:44 schrieb Martin Vermeer:
>
> > OK if I commit this? It's your fix as much as mine
>
> Yes, of course.
Done.
- Martin
pgpF6emm1yB6w.pgp
Description: PGP signature
Am Dienstag, 28. Februar 2006 16:15 schrieb Georg Baum:
> We can be sure that it does not break anything that was not already
broken
> before Michael did fix the "insert delimiters around selection" bug,
Of course that was Martin.
Sorry,
Georg
Am Dienstag, 28. Februar 2006 18:44 schrieb Martin Vermeer:
> OK if I commit this? It's your fix as much as mine
Yes, of course.
Georg
On Tue, Feb 28, 2006 at 05:30:49PM +0100, Lars Gullik Bjønnes wrote:
> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>
> | > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
> |
> | Georg> What makes me
> | Georg> also sure that this patch is correct is the fact that
> | Georg> niceInsert
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
| > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
|
| Georg> We can be sure that it does not break anything that was not
| Georg> already broken before Michael did fix the "insert delimiters
| Georg> around selection" bug, because the part
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> We can be sure that it does not break anything that was not
Georg> already broken before Michael did fix the "insert delimiters
Georg> around selection" bug, because the part of the patch that
Georg> touches niceInsert() simply reverts
On Tue, 2006-02-28 at 16:19 +0100, Georg Baum wrote:
> Martin Vermeer wrote:
>
> > How relevant is the semantics of non-working code?
>
> It is very important;-)
>
> > LCursor::paste(data) takes a string, and calls LFUN_PASTE with that
> > string as the data to be pasted. Correct syntax would be
Martin Vermeer wrote:
> How relevant is the semantics of non-working code?
It is very important;-)
> LCursor::paste(data) takes a string, and calls LFUN_PASTE with that
> string as the data to be pasted. Correct syntax would be to call with
> the buffer number to be pasted from. It cannot and do
Jean-Marc Lasgouttes wrote:
> What bothers me with this patch is that I never really understood what
> the semantics of niceInsert are (wrt other inserts). So how can we be
> sure that the patch does not break something else?
We can be sure that it does not break anything that was not already bro
On Tue, 2006-02-28 at 10:55 +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> >> If we can get some more people to test this and also test other
> >> operations to try to make sure that no regressions are introcuced,
> >> then if all agree we can
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> If we can get some more people to test this and also test other
>> operations to try to make sure that no regressions are introcuced,
>> then if all agree we can have this too for 1.4.0.
Martin> Did the following tests.
What bothers
On Tue, 2006-02-28 at 16:19 +0200, Martin Vermeer wrote:
> On Tue, 2006-02-28 at 13:02 +0100, Lars Gullik Bjønnes wrote:
> > Martin Vermeer <[EMAIL PROTECTED]> writes:
...
> ...but I may soon have a patch for the above problem...
>
Being
"Only, with 2), and even with 1) \textrm, it is possible
On Tue, 2006-02-28 at 13:02 +0100, Lars Gullik Bjønnes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> | On Mon, 2006-02-27 at 14:55 +0100, Lars Gullik Bjønnes wrote:
> | > Joost Verburg <[EMAIL PROTECTED]> writes:
> | >
> | > | Georg Baum wrote:
> | > | > Fortunately this is easy to fix
Lars Gullik Bjønnes wrote:
> do you think this is enough testing for 1.4.0?
I also did some more testing, and found no problem except one that also
exists without the patch: http://bugzilla.lyx.org/show_bug.cgi?id=2331
I would say that the patch is tested enough for 1.4.0.
Lars, do you agree? W
Martin Vermeer <[EMAIL PROTECTED]> writes:
| On Mon, 2006-02-27 at 14:55 +0100, Lars Gullik Bjønnes wrote:
| > Joost Verburg <[EMAIL PROTECTED]> writes:
| >
| > | Georg Baum wrote:
| > | > Fortunately this is easy to fix, see the attached patch. (...)
| > | > I agree with Joost that it should be
On Mon, 2006-02-27 at 14:55 +0100, Lars Gullik Bjønnes wrote:
> Joost Verburg <[EMAIL PROTECTED]> writes:
>
> | Georg Baum wrote:
> | > Fortunately this is easy to fix, see the attached patch. (...)
> | > I agree with Joost that it should be in 1.4.0. This is a major
> | > problem, and LCursor::pa
Georg Baum wrote:
> The attached nearly untested patch fixes math-insert (bug 2315). 'fixes'
> means revert to 1.3 behaviour: Require $...$ (or any other valid formula
> delimiters). If no delimiters are present, create a black 'pseudo
> formula'.
> Please test.
Works for me.
Jürgen
Joost Verburg <[EMAIL PROTECTED]> writes:
| Georg Baum wrote:
| > Fortunately this is easy to fix, see the attached patch. (...)
| > I agree with Joost that it should be in 1.4.0. This is a major
| > problem, and LCursor::paste() is so utterly broken that every
| > replacement that works at least
Georg Baum wrote:
Fortunately this is easy to fix, see the attached patch. (...)
I agree with Joost that it should be in 1.4.0. This is a major problem,
and LCursor::paste() is so utterly broken that every replacement that
works at least in one single case is better.
I have tested this patch
On Mon, 2006-02-27 at 10:29 +0100, Georg Baum wrote:
> Am Sonntag, 26. Februar 2006 20:53 schrieb Martin Vermeer:
> > Attached the best I can come up with for now. Working are:
> >
> > 1) fonts from the panel around selection
> > 2) decorations from the panel over/under selection
> > 3) compound s
Am Sonntag, 26. Februar 2006 20:53 schrieb Martin Vermeer:
> Attached the best I can come up with for now. Working are:
>
> 1) fonts from the panel around selection
> 2) decorations from the panel over/under selection
> 3) compound symbols from the panel, type \mathbb R, without sel
> 4) same with
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
>> you mean \mathbb{R}, then select and C-M? Typing \mathbbR
>> gives the expected result to me.
Andre> That this space is rquired is also a regression and I do not
Andre> really remember leaving mathed in this state. Could this be
Andre>
Martin Vermeer wrote:
Attached the best I can come up with for now. (...)
I propose this as the patch for 1.4.1 (not 1.4.0 I think; it's cosmetic
and there's a workaround).
But what about only the math panel issue? I think there should be at
least a patch to fix that in 1.4.0 since it is a m
On Sun, Feb 26, 2006 at 07:25:51PM +0100, Georg Baum wrote:
> Am Sonntag, 26. Februar 2006 17:53 schrieb Martin Vermeer:
> > Yes... but now insertion of a decoration "around" selected math text
> > fails. The problem which this patch originally tried to fix.
>
> Of course. The patch was only meant
On Sun, Feb 26, 2006 at 07:25:51PM +0100, Georg Baum wrote:
> Am Sonntag, 26. Februar 2006 17:53 schrieb Martin Vermeer:
...
> > The assumption here appears to be that the argument to give to the
> > LFUN_PASTE call is the _text_ to be pasted into the doc. Checking the
> > places where LFUN_PAST
Am Sonntag, 26. Februar 2006 17:53 schrieb Martin Vermeer:
> Yes... but now insertion of a decoration "around" selected math text
> fails. The problem which this patch originally tried to fix.
Of course. The patch was only meant to show where the problem is, it was
by no means a finished fix.
>
On Sun, Feb 26, 2006 at 03:24:52PM +0100, Georg Baum wrote:
> Am Samstag, 25. Februar 2006 18:19 schrieb Martin Vermeer:
...
> > For blackboard bold R (real numbers) we have "\\mathbb R".
>
> which is BTW valid TeX syntax.
>
> > When you inspect the code handling this, more precisely
> > Contro
Am Samstag, 25. Februar 2006 19:39 schrieb Andre Poenitz:
> On Sat, Feb 25, 2006 at 04:36:58PM +0100, Juergen Spitzmueller wrote:
> > math-insert is broken in general :-(
>
> Could this be related to somebody insisting on (a) doing clever things
> in text->math conversation (i.e. adding 'missing'
Am Samstag, 25. Februar 2006 16:36 schrieb Juergen Spitzmueller:
> Joost Verburg wrote:
> > Typing the LaTeX command manually also gives weird behavior and not
the
> > expected result.
>
> you mean \mathbb{R}, then select and C-M?
> Typing \mathbbR gives the expected result to me.
The reason for
Am Samstag, 25. Februar 2006 18:19 schrieb Martin Vermeer:
> First of all, the bug is unrelated to text->math conversion. You should
> look at ControlMath.C. There, the command texts associated with each
> symbol in the math symbol panels, executed when clicking on them, are
> defined.
>
> For bla
On Sat, Feb 25, 2006 at 07:45:53PM +0100, Andre Poenitz wrote:
> On Sat, Feb 25, 2006 at 07:19:31PM +0200, Martin Vermeer wrote:
> > For blackboard bold R (real numbers) we have "\\mathbb R".
>
> Why doesn't it try \mathbb{R} or such? Shouldn't that be parsed
> better?
Perhaps... I tried that. It
On Sat, Feb 25, 2006 at 07:19:31PM +0200, Martin Vermeer wrote:
> For blackboard bold R (real numbers) we have "\\mathbb R".
Why doesn't it try \mathbb{R} or such? Shouldn't that be parsed
better?
> [...]
> Angus is marked as being to 'blame' for this part of the code, but that
> proves little fo
On Sat, Feb 25, 2006 at 04:36:58PM +0100, Juergen Spitzmueller wrote:
> Joost Verburg wrote:
> > I'm trying to insert one of the matbb/mathcal/mathrm symbols in a
> > document using the math panel, for example the double-barred R: \mathbb{R}.
> >
> > Nothing appears on the screen and when I look at
On Sat, Feb 25, 2006 at 04:47:31PM +0100, Juergen Spitzmueller wrote:
> Also sprach Joost Verburg:
> > The main problem is that the math panel doesn't work. Try to insert one
> > of the mathbb symbols using the math panel and you get an empty inset
> > instead of the symbol.
>
> I know, I can repr
Also sprach Joost Verburg:
> This is bad. I guess I found another bug that didn't look very important
> (text>math broken) but is quite major (math panel broken).
I think so, too.
Jürgen
Juergen Spitzmueller wrote:
The main problem is that the math panel doesn't work. Try to insert one
of the mathbb symbols using the math panel and you get an empty inset
instead of the symbol.
I know, I can reproduce that. I just wanted to point out that the bug is IMHO
the same as the one for
On Sat, Feb 25, 2006 at 04:28:03PM +0100, Joost Verburg wrote:
> Daniel Watkins wrote:
> >Within the maths environment of LyX, typing any of the above commands (in
> >this case \mathbb) creates an inset of that type (i.e. a box within which
> >everything typed will be in, for example, \mathbb). You
Also sprach Joost Verburg:
> The main problem is that the math panel doesn't work. Try to insert one
> of the mathbb symbols using the math panel and you get an empty inset
> instead of the symbol.
I know, I can reproduce that. I just wanted to point out that the bug is IMHO
the same as the one f
Juergen Spitzmueller wrote:
you mean \mathbb{R}, then select and C-M?
Typing \mathbbR gives the expected result to me.
Jürgen
The main problem is that the math panel doesn't work. Try to insert one
of the mathbb symbols using the math panel and you get an empty inset
instead of the symbol.
Joost Verburg wrote:
> I'm trying to insert one of the matbb/mathcal/mathrm symbols in a
> document using the math panel, for example the double-barred R: \mathbb{R}.
>
> Nothing appears on the screen and when I look at the saved LyX file it
> contains only an empty mathbb command: \mathbb{}. When
Daniel Watkins wrote:
Within the maths environment of LyX, typing any of the above commands (in
this case \mathbb) creates an inset of that type (i.e. a box within which
everything typed will be in, for example, \mathbb). You then have to place
the cursor within this inset to use the font correct
Joost Verburg wrote:
> I'm trying to insert one of the matbb/mathcal/mathrm symbols in a
> document using the math panel, for example the double-barred R:
> \mathbb{R}.
>
> Nothing appears on the screen and when I look at the saved LyX file it
> contains only an empty mathbb command: \mathbb{}. Wh
46 matches
Mail list logo
