Re: lyx-2.3.0alpha1-1 crash

2017-06-12 Thread Scott Kostyshak
On Sun, Jun 11, 2017 at 09:16:07PM +0200, Guillaume MM wrote: > Le 10/06/2017 à 00:34, Scott Kostyshak a écrit : > > On Thu, Jun 01, 2017 at 01:43:11PM -0400, PhilipPirrip wrote: > > > On 05/28/2017 08:20 AM, Guillaume MM wrote: > > > > Here is a patch, reviews are welcome. > > > > > > Can't say m

Re: lyx-2.3.0alpha1-1 crash

2017-06-11 Thread Guillaume MM
Le 10/06/2017 à 00:34, Scott Kostyshak a écrit : On Thu, Jun 01, 2017 at 01:43:11PM -0400, PhilipPirrip wrote: On 05/28/2017 08:20 AM, Guillaume MM wrote: Here is a patch, reviews are welcome. Can't say much about the patch, but want to confirm that LyX is not crashing any more. Also pinging

Re: lyx-2.3.0alpha1-1 crash

2017-06-09 Thread Scott Kostyshak
On Thu, Jun 01, 2017 at 01:43:11PM -0400, PhilipPirrip wrote: > On 05/28/2017 08:20 AM, Guillaume MM wrote: > > Here is a patch, reviews are welcome. > > Can't say much about the patch, but want to confirm that LyX is not crashing > any more. > > Also pinging others to review the code, I think th

Re: lyx-2.3.0alpha1-1 crash

2017-06-01 Thread PhilipPirrip
On 05/28/2017 08:20 AM, Guillaume MM wrote: Here is a patch, reviews are welcome. Can't say much about the patch, but want to confirm that LyX is not crashing any more. Also pinging others to review the code, I think this is a pretty nasty bug that definitely needs more testing.

Re: lyx-2.3.0alpha1-1 crash

2017-05-28 Thread Guillaume MM
Le 26/05/2017 à 23:04, PhilipPirrip a écrit : I think I caught this one too. I was working on a document with a few float figures exported from inkscape as pdf, LyX 2.3.0alpha1 crashed after updating (saving as pdf) one of the figures. I was running J. Matos' version from https://copr.fedorai

Re: lyx-2.3.0alpha1-1 crash

2017-05-27 Thread Guillaume MM
Le 27/05/2017 à 00:56, Guillaume MM a écrit : Thread 1 "lyx" received signal SIGSEGV, Segmentation fault. 0x768612ef in QFileInfo::absoluteFilePath() const () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #0 0x768612ef in QFileInfo::absoluteFilePath() const () from /u

Re: lyx-2.3.0alpha1-1 crash

2017-05-26 Thread Guillaume MM
Le 26/05/2017 à 23:29, Guillaume MM a écrit : Le 26/05/2017 à 23:15, PhilipPirrip a écrit : On 05/26/2017 05:04 PM, PhilipPirrip wrote: I think I caught this one too. I was working on a document with a few float figures exported from inkscape as pdf, LyX 2.3.0alpha1 crashed after updating (s

Re: lyx-2.3.0alpha1-1 crash

2017-05-26 Thread Guillaume MM
Le 26/05/2017 à 23:15, PhilipPirrip a écrit : On 05/26/2017 05:04 PM, PhilipPirrip wrote: I think I caught this one too. I was working on a document with a few float figures exported from inkscape as pdf, LyX 2.3.0alpha1 crashed after updating (saving as pdf) one of the figures. I was running

Re: lyx-2.3.0alpha1-1 crash

2017-05-26 Thread PhilipPirrip
On 05/26/2017 05:04 PM, PhilipPirrip wrote: I think I caught this one too. I was working on a document with a few float figures exported from inkscape as pdf, LyX 2.3.0alpha1 crashed after updating (saving as pdf) one of the figures. I was running J. Matos' version from https://copr.fedorainf

Re: LyX 2.3.0alpha1-1

2017-05-03 Thread Scott Kostyshak
On Wed, May 03, 2017 at 07:32:13AM +0200, Kornel Benko wrote: > Am Dienstag, 2. Mai 2017 um 19:19:44, schrieb Scott Kostyshak > > > On Tue, May 02, 2017 at 08:24:40AM +0200, Kornel Benko wrote: > > > Am Montag, 1. Mai 2017 um 20:25:44, schrieb Scott Kostyshak > > > > > > > > > Kornel, which co

Re: LyX 2.3.0alpha1-1

2017-05-02 Thread Kornel Benko
Am Dienstag, 2. Mai 2017 um 19:19:44, schrieb Scott Kostyshak > On Tue, May 02, 2017 at 08:24:40AM +0200, Kornel Benko wrote: > > Am Montag, 1. Mai 2017 um 20:25:44, schrieb Scott Kostyshak > > > > > > Kornel, which commits should I cherry-pick from master to > > > 2.3.0-alpha1-x? i.e. which co

Re: LyX 2.3.0alpha1-1

2017-05-02 Thread Scott Kostyshak
On Tue, May 02, 2017 at 08:24:40AM +0200, Kornel Benko wrote: > Am Montag, 1. Mai 2017 um 20:25:44, schrieb Scott Kostyshak > > Kornel, which commits should I cherry-pick from master to > > 2.3.0-alpha1-x? i.e. which commits do I need for Uwe to build from the > > tar ball? > > I committed it no

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Kornel Benko
Am Montag, 1. Mai 2017 um 20:25:44, schrieb Scott Kostyshak > On Mon, May 01, 2017 at 09:54:47PM +0200, Uwe Stöhr wrote: > > El 01.05.2017 a las 18:53, Uwe Stöhr escribió: > > > > > Wohoo, I finally found the problem: > > > > Here is the installer: > > > > http://ftp.lyx.de/LyXWinInstaller/LyX2

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Scott Kostyshak
On Mon, May 01, 2017 at 09:54:47PM +0200, Uwe Stöhr wrote: > El 01.05.2017 a las 18:53, Uwe Stöhr escribió: > > > Wohoo, I finally found the problem: > > Here is the installer: > > http://ftp.lyx.de/LyXWinInstaller/LyX2.3alpha1/ > > Please check the signature. > > The only change I had to make

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Uwe Stöhr
El 01.05.2017 a las 19:33, Kornel Benko escribió: if (WIN32) set(suffixing ${LYX_PACKAGE_SUFFIX}) else() set(suffixing ${LYX_PROGRAM_SUFFIX}) endif() if(suffixing) set(PACKAGE ${PACKAGE_BASE}${LYX_INSTALL_SUFFIX}) else() set(PACKAGE ${PACKAGE_BASE}) endif() This

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Uwe Stöhr
El 01.05.2017 a las 18:53, Uwe Stöhr escribió: Wohoo, I finally found the problem: Here is the installer: http://ftp.lyx.de/LyXWinInstaller/LyX2.3alpha1/ Please check the signature. The only change I had to make in the tarball files is the attached one. As this does not change anything in

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Kornel Benko
Am Montag, 1. Mai 2017 um 18:53:21, schrieb Uwe Stöhr > El 01.05.2017 a las 17:57, Uwe Stöhr escribió: > > Wohoo, I finally found the problem: > - the file config.h is created by CMake > - in its line number 33 there is: >#define PACKAGE "LyX" > - if I change it manyually to >#define PACK

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Uwe Stöhr
El 01.05.2017 a las 17:57, Uwe Stöhr escribió: Wohoo, I finally found the problem: - the file config.h is created by CMake - in its line number 33 there is: #define PACKAGE "LyX" - if I change it manyually to #define PACKAGE "LyX2.3" I get what I need. the bug is in CmakeLists.txt line 465

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Kornel Benko
Am Montag, 1. Mai 2017 um 17:48:55, schrieb Uwe Stöhr > El 01.05.2017 a las 12:52, Kornel Benko escribió: > > > It is available here. > > Not here: I took latest master, deleted the CMake cache and set up > everything from scratch. As you can see in the attached screenshot there > is no LYX_PR

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Kornel Benko
Am Montag, 1. Mai 2017 um 17:57:05, schrieb Uwe Stöhr > El 01.05.2017 a las 17:48, Uwe Stöhr escribió: > > > Moreover, as you can see in the screenshot, I get now many warnings > > since your latest commit > > http://www.lyx.org/trac/changeset/d74c43e7a307d381e71251d5e376f8629e5aa3d9/lyxgit > >

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Uwe Stöhr
El 01.05.2017 a las 17:48, Uwe Stöhr escribió: Moreover, as you can see in the screenshot, I get now many warnings since your latest commit http://www.lyx.org/trac/changeset/d74c43e7a307d381e71251d5e376f8629e5aa3d9/lyxgit Ah, it seems that i can ignore them, right? Another issue: I can now s

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Kornel Benko
Am Montag, 1. Mai 2017 um 12:39:30, schrieb Uwe Stöhr > El 01.05.2017 a las 07:08, Kornel Benko escribió: > > >> But I don't, or the version suffix for the appdata folder is set at > >> another place, but where? > > > > Have you set > > -DLYX_PROGRAM_SUFFIX=ON > > No because this setting is

Re: LyX 2.3.0alpha1-1

2017-05-01 Thread Uwe Stöhr
El 01.05.2017 a las 07:08, Kornel Benko escribió: But I don't, or the version suffix for the appdata folder is set at another place, but where? Have you set -DLYX_PROGRAM_SUFFIX=ON No because this setting is not available in the CMake GUI. I set it now via the build script but the p

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Kornel Benko
Am Montag, 1. Mai 2017 um 00:17:37, schrieb Uwe Stöhr > El 30.04.2017 a las 16:11, Kornel Benko escribió: > > >> I thing we should use > >> Qt5 as default for LyX 2.3. One can still override it with Qt 4 if one > >> likes. > > > > The same reasoning applies to to QT5. > > No, because Qt 4 suppo

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Scott Kostyshak
On Mon, May 01, 2017 at 12:22:08AM +0200, Uwe Stöhr wrote: > El 30.04.2017 a las 18:54, Scott Kostyshak escribió: > > > I think it is still reasonable to use Qt 4 by default. Many > > distributions still have old Qt 5 libraries, and we recommend only 5.6. > > Well, a few weeks ago you even wanted

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Uwe Stöhr
El 30.04.2017 a las 18:54, Scott Kostyshak escribió: I think it is still reasonable to use Qt 4 by default. Many distributions still have old Qt 5 libraries, and we recommend only 5.6. Well, a few weeks ago you even wanted to use the latest Qt 5 version. I argued to use the current long-term

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Uwe Stöhr
El 30.04.2017 a las 16:11, Kornel Benko escribió: I thing we should use Qt5 as default for LyX 2.3. One can still override it with Qt 4 if one likes. The same reasoning applies to to QT5. No, because Qt 4 support is running out. I therefore it makes sense to switch to a system for which we

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Scott Kostyshak
On Sun, Apr 30, 2017 at 05:27:20PM +0200, Kornel Benko wrote: > Am Sonntag, 30. April 2017 um 10:56:32, schrieb Scott Kostyshak > > > On Sun, Apr 30, 2017 at 04:11:31PM +0200, Kornel Benko wrote: > > > > > > Attached is a patch for CMake. Does it make sense? > > > > > > Sure. > > > > I suggest

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Kornel Benko
Am Sonntag, 30. April 2017 um 10:56:32, schrieb Scott Kostyshak > On Sun, Apr 30, 2017 at 04:11:31PM +0200, Kornel Benko wrote: > > > > Attached is a patch for CMake. Does it make sense? > > > > Sure. > > I suggest either of you commit any patch that you both agree on to > master. Then let me

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Scott Kostyshak
On Sun, Apr 30, 2017 at 04:11:31PM +0200, Kornel Benko wrote: > > Attached is a patch for CMake. Does it make sense? > > Sure. I suggest either of you commit any patch that you both agree on to master. Then let me know which commits I should cherry-pick from the 2.3.0-alpha1-x branch. Scott s

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Kornel Benko
Am Sonntag, 30. April 2017 um 15:38:30, schrieb Uwe Stöhr > El 30.04.2017 a las 10:24, Kornel Benko escribió: > > > Am Sonntag, 30. April 2017 um 09:37:37, schrieb Kornel Benko > > > >>> I found now the problem: configuring CMake the fist time will set > >>> PYTHON_EXECUTABLE and LYX_PYTHON_EXE

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Uwe Stöhr
El 30.04.2017 a las 10:24, Kornel Benko escribió: Am Sonntag, 30. April 2017 um 09:37:37, schrieb Kornel Benko I found now the problem: configuring CMake the fist time will set PYTHON_EXECUTABLE and LYX_PYTHON_EXECUTABLE to the python library found in the specified GNUWIN32_DIR: D:/LyXGit/Mast

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Kornel Benko
Am Sonntag, 30. April 2017 um 09:37:37, schrieb Kornel Benko > > I found now the problem: configuring CMake the fist time will set > > PYTHON_EXECUTABLE and LYX_PYTHON_EXECUTABLE to the python library found > > in the specified GNUWIN32_DIR: > > D:/LyXGit/Master/lyx-windows-deps-msvc2015/Python/

Re: LyX 2.3.0alpha1-1

2017-04-30 Thread Kornel Benko
Am Sonntag, 30. April 2017 um 04:23:07, schrieb Uwe Stöhr > El 30.04.2017 a las 03:48, Uwe Stöhr escribió: > > > Fixing this in the Cmake Gui leads me to this error which I cannot > > overcome: > > > > C:\Program Files > > (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(133,5

Re: LyX 2.3.0alpha1-1

2017-04-29 Thread Uwe Stöhr
El 30.04.2017 a las 03:48, Uwe Stöhr escribió: Fixing this in the Cmake Gui leads me to this error which I cannot overcome: C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(133,5): error MSB3073: Der Befehl "setlocal\r I found now the problem: configuring