Re: LyX/Mac-Qt4 Profile

2006-05-22 Thread Andre Poenitz
On Fri, May 19, 2006 at 11:50:50PM +0200, Abdelrazak Younes wrote: > It seems that font_metrics::width is called two times within > LyXText::redoParagraph, once in LyXText::rowBreakPoint and another in > ::RowPainter::paintChars; I think this could be optimized out, Martin? It's not easy. We tri

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> I'm not convinced. How? And isn't this (font metrics) being Martin> cached in Qt? It is supposed to, indeed. We still have some caching code for older qt3 versions. You may want to reactivate it and see what happens. JMarc

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Martin Vermeer a écrit : It doesn't look to me that this is caching anything. Is it? Right, now I look at it, it should be something like this: if (!fi) fi = new QLFontInfo(f); fontinfo_[f.family()][f.series()][f.realShape()][f.size()] = fi; return *fi;

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Sat, May 20, 2006 at 03:32:05PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes a écrit : Martin Vermeer a écrit : ... Hum, this code in "qfont_loader.C" looks suspicious: __ QLFontInfo & fontinfo(LyXFont const &

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Martin Vermeer
On Sat, May 20, 2006 at 03:32:05PM +0200, Abdelrazak Younes wrote: > Abdelrazak Younes a écrit : > >Martin Vermeer a écrit : ... > Hum, this code in "qfont_loader.C" looks suspicious: > __ > > QLFontInfo & fontinfo(LyXFont const & f) { > QLFontInfo * & fi

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Martin Vermeer
On Sat, May 20, 2006 at 01:46:42PM +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : ... > >>It seems that font_metrics::width is called two times within > >>LyXText::redoParagraph, once in LyXText::rowBreakPoint and another in > >>::RowPainter::paintChars; I think this could be optimi

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Martin Vermeer a écrit : On Fri, May 19, 2006 at 11:50:50PM +0200, Abdelrazak Younes wrote: | | | | + 510.6 ms LyXText::rowBreakPoint(int, Row&) const (lyx) | | | | | + 457.7 ms font_metrics::width(char, LyXFont const&) (lyx) | | | | + 2417.1 ms ::RowPainter::paint

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Fri, May 19, 2006 at 11:50:50PM +0200, Abdelrazak Younes wrote: | | | | + 510.6 ms LyXText::rowBreakPoint(int, Row&) const (lyx) | | | | | + 457.7 ms font_metrics::width(char, LyXFont const&) (lyx) | | | | + 2417.1 ms ::RowPainter::paintFromPos(int&) (lyx) | | | |

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Martin Vermeer
On Fri, May 19, 2006 at 11:50:50PM +0200, Abdelrazak Younes wrote: > Bennett Helm a écrit : > >generate a report with those data.) Nonetheless, what's obvious from > >that is the amount of time spent in QPainter (see, e.g., near the top > >and near the bottom; for the latter, the 1710.0 ms is for

Re: LyX/Mac-Qt4 Profile

2006-05-20 Thread Lars Gullik Bjønnes
Bennett Helm <[EMAIL PROTECTED]> writes: | On May 19, 2006, at 11:34 AM, Abdelrazak Younes wrote: | | > No, I think it would be better if you pass | > --disable-debug --disable-stdlib-debug | > instead of: | > --enable-debug --enable-stdlib-debug | | Without --enable-debug, at least, I c

Re: LyX/Mac-Qt4 Profile

2006-05-19 Thread Abdelrazak Younes
Bennett Helm a écrit : generate a report with those data.) Nonetheless, what's obvious from that is the amount of time spent in QPainter (see, e.g., near the top and near the bottom; for the latter, the 1710.0 ms is for the whole tree, but of that QPainter takes up 1695.7 ms), font_metrics::wid

Re: LyX/Mac-Qt4 Profile

2006-05-19 Thread Bennett Helm
On May 19, 2006, at 2:36 PM, Abdelrazak Younes wrote: Bennett Helm a écrit : On May 19, 2006, at 12:13 PM, Abdelrazak Younes wrote: I can do that too. There are 2 options for sorting the report -- via a column labeled "Self" and one labeled "Total". This (as my others have been) is sorted b

Re: LyX/Mac-Qt4 Profile

2006-05-19 Thread Abdelrazak Younes
Bennett Helm a écrit : On May 19, 2006, at 12:13 PM, Abdelrazak Younes wrote: I can do that too. There are 2 options for sorting the report -- via a column labeled "Self" and one labeled "Total". This (as my others have been) is sorted by "Total", again arbitrarily cut near the top. Let me kn

Re: LyX/Mac-Qt4 Profile

2006-05-19 Thread Bennett Helm
On May 19, 2006, at 12:13 PM, Abdelrazak Younes wrote: Bennett Helm a écrit : On May 19, 2006, at 11:34 AM, Abdelrazak Younes wrote: No, I think it would be better if you pass --disable-debug --disable-stdlib-debug instead of: --enable-debug --enable-stdlib-debug Without --enable-debug

Re: LyX/Mac-Qt4 Profile

2006-05-19 Thread Abdelrazak Younes
Bennett Helm a écrit : On May 19, 2006, at 11:34 AM, Abdelrazak Younes wrote: No, I think it would be better if you pass --disable-debug --disable-stdlib-debug instead of: --enable-debug --enable-stdlib-debug Without --enable-debug, at least, I can't get function names in the profile

Re: LyX/Mac-Qt4 Profile

2006-05-19 Thread Bennett Helm
On May 19, 2006, at 11:34 AM, Abdelrazak Younes wrote: No, I think it would be better if you pass --disable-debug --disable-stdlib-debug instead of: --enable-debug --enable-stdlib-debug Without --enable-debug, at least, I can't get function names in the profile. You use cas

Re: LyX/Mac-Qt4 Profile

2006-05-19 Thread Abdelrazak Younes
Bennett Helm a écrit : Well, here is the beginning of the profile report -- arbitrarily cut off near the top. As I have done with previous profiles, this is produced with: tree view; system libraries charged to callers; 30-second sample, with me typing constantly during the sampling. LyX was