Re: InsetCitation patch

2000-07-07 Thread Juergen Vigna
On 06-Jul-2000 Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > >| explicit >| InsetCitation(string const & key, string const & note = string()); >| : InsetCommand("cite", key, note) {} >| >| Does it help if you split this into two? >| src/insets/i

Re: InsetCitation patch

2000-07-06 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Ah! Yes. I would NEVER have got this! Thanks Lars. Could you | (someone) shove I have come across those buggers before :-) Lgb

Re: InsetCitation patch

2000-07-06 Thread Angus Leeming
Lars> Do you have #pragma interface in insetcite.h, but no #pragma Lars> implementation in insetcite.C? Ah! Yes. I would NEVER have got this! Thanks Lars. Could you (someone) shove #ifdef __GNUG__ #pragma implementation #endif into insetcite.C Angus PS, Baruch. You should modify the patch

Re: InsetCitation patch

2000-07-06 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | explicit | InsetCitation(string const & key, string const & note = string()); | : InsetCommand("cite", key, note) {} | | Does it help if you split this into two? | src/insets/insetcite.h: | explicit | InsetCitation

RE: InsetCitation patch

2000-07-06 Thread Angus Leeming
Jürgen> Well I applied it here on my local tree, can compile now but on linking Jürgen> I get: Jürgen> -lc -lm -L/usr/X11R6/lib -lX11 Jürgen> buffer.o: In function `Buffer::parseSingleLyXformat2Token(LyXLex &, LyXParagraph *&, Jürgen> LyXParagraph *&, lyxstring const &, int &, char &, LyXFont &

RE: InsetCitation patch

2000-07-06 Thread Juergen Vigna
On 06-Jul-2000 Angus Leeming wrote: > Jürgen> NOT good this should be generated automatically from the .fd file, so > Jürgen> if you have to make changes to it which cannot be handled by the sed-logic > Jürgen> in the Makefile you have to use a patch which is automatically applied > Jürgen> every

RE: InsetCitation patch

2000-07-06 Thread Angus Leeming
Jürgen> NOT good this should be generated automatically from the .fd file, so Jürgen> if you have to make changes to it which cannot be handled by the sed-logic Jürgen> in the Makefile you have to use a patch which is automatically applied Jürgen> every time the fd-file is edited! Ok. The both pr

RE: InsetCitation patch

2000-07-06 Thread Juergen Vigna
On 06-Jul-2000 Angus Leeming wrote: > Jürgen> Why do you need also form_citation.[Ch]? They should be autogenerated by > Jürgen> the Makefile in the forms/ subdirectory, aren't they? > > Almost :-) I had to make two TINY changes: > > * in form_citation.h, DEC cxx complains about : > typedef str

RE: InsetCitation patch

2000-07-06 Thread Angus Leeming
Jürgen> Why do you need also form_citation.[Ch]? They should be autogenerated by Jürgen> the Makefile in the forms/ subdirectory, aren't they? Almost :-) I had to make two TINY changes: * in form_citation.h, DEC cxx complains about : typedef struct { ... } FD_form_citation; So I changed

RE: InsetCitation patch

2000-07-06 Thread Juergen Vigna
On 06-Jul-2000 Angus Leeming wrote: > Good morning. > > Attached is a patch for a GUI-independent InsetCitation class and associated > xforms dialog class FormCitation. > > The file expands to > > PATCH06July2000/ > PATCH06July2000/patch > PATCH06July2000/FormCitation.C > PATCH06July2000/FormC