[PATCH] Re: [PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-21 Thread Martin Vermeer
On Wed, 2005-10-19 at 17:53 +0200, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > > Here is the patch FWIW. I still think it would be worth committing it. I agree, but with the attached mod. It essentially removes the cursor from inside t

Re: [PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-20 Thread Martin Vermeer
On Wed, 2005-10-19 at 17:53 +0200, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > I really cannot make sense of it. > > Martin, Help!!! Jean-Marc, If I place another line of text under the inset, the nature of the error message changes.

Re: [PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-20 Thread Martin Vermeer
On Wed, 2005-10-19 at 21:25 +0300, Martin Vermeer wrote: > On Wed, Oct 19, 2005 at 05:53:07PM +0200, Jean-Marc Lasgouttes wrote: > > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > Yes... look at cursor.C: > > 1201 LyXFont LCursor::getFont() const >1202 { >1203

Re: [PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-19 Thread Martin Vermeer
On Wed, Oct 19, 2005 at 05:53:07PM +0200, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > Jean-Marc> Basically, dEPM compares the tips of cursors without caring > Jean-Marc> whether they are at same depth (insert apples and oranges > Jean-Mar

[PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-19 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Basically, dEPM compares the tips of cursors without caring Jean-Marc> whether they are at same depth (insert apples and oranges Jean-Marc> comment here). Here undo is called between two cursors at Jean-Marc> differen

Re: Crash on cursor movement around inset

2005-10-13 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> OK, at least part of this patch was tested by me and found Martin> functional. Saw no side effects (and couldn't really imagine Martin> any). So, I would say, put it in. I did that. JMarc

Re: Crash on cursor movement around inset

2005-10-07 Thread Martin Vermeer
On Fri, Oct 07, 2005 at 04:04:10PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Fri, 2005-10-07 at 15:30 +0200, Jean-Marc Lasgouttes wrote: > >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > Martin> You're i

Re: selection_position_was_oldcursor_position (Re: Crash on cursor movement around inset)

2005-10-07 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Fri, 2005-10-07 at 13:58 +0200, Jean-Marc Lasgouttes wrote: | > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: | > | > Martin> Eh, we're talking about deleteEmptyParagraphMechanism | > Martin> (*Paragraph*! Or does this handle double b

Re: Crash on cursor movement around inset

2005-10-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Fri, 2005-10-07 at 15:30 +0200, Jean-Marc Lasgouttes wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Martin> You're in good company. But your patch works... for page down. Martin> Apparently it shoul

Re: Crash on cursor movement around inset

2005-10-07 Thread Martin Vermeer
On Fri, 2005-10-07 at 15:30 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> You're in good company. But your patch works... for page down. > Martin> Apparently it should be extended for cursorPrevious ;-) > > Yes, I mentioned that in m

Re: Crash on cursor movement around inset

2005-10-07 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> This is fixed by the attached patch, that I propose to Jean-Marc> apply (thoughts?). And the patch. JMarc Index: src/text2.C === RCS file: /usr/local/

Re: Crash on cursor movement around inset

2005-10-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Here's a better backtrace (and yes, it crashes just as well Martin> without the speedup patch!): The problem is that cursorDown uses editXY to set the cursor, and forgets to rest the anchor. Therefore the anchor is at a lower de

Re: Crash on cursor movement around inset

2005-10-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> You're in good company. But your patch works... for page down. Martin> Apparently it should be extended for cursorPrevious ;-) Yes, I mentioned that in my message. Should I apply it as-is or try to use metrics() instead of updat

Re: Crash on cursor movement around inset

2005-10-07 Thread Martin Vermeer
On Fri, 2005-10-07 at 11:43 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Note BTW that not only does cursor up do the same thing, but > Martin> pressing page up/down in an empty paragraph (_without_ any > Martin> inset, without any n

Re: Crash on cursor movement around inset

2005-10-07 Thread Martin Vermeer
On Fri, 2005-10-07 at 11:34 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> This looks like a biggie. Fortunately nothing to do with > Martin> speed-up patch... Jean-Marc, how is your testing going ;-) > > About the speed-up patch? Sin

Re: selection_position_was_oldcursor_position (Re: Crash on cursor movement around inset)

2005-10-07 Thread Martin Vermeer
On Fri, 2005-10-07 at 13:58 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Eh, we're talking about deleteEmptyParagraphMechanism > Martin> (*Paragraph*! Or does this handle double blanks too?). > > It does both. > > Martin> And at th

Re: selection_position_was_oldcursor_position (Re: Crash on cursor movement around inset)

2005-10-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Eh, we're talking about deleteEmptyParagraphMechanism Martin> (*Paragraph*! Or does this handle double blanks too?). It does both. Martin> And at the beginning (text2.C) we have Martin>1184 // Would be wrong to delete anyt

Re: Crash on cursor movement around inset

2005-10-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Note BTW that not only does cursor up do the same thing, but Martin> pressing page up/down in an empty paragraph (_without_ any Martin> inset, without any noindent, irrespective of empty par Martin> history) will crash lyx: This

Re: selection_position_was_oldcursor_position (Re: Crash on cursor movement around inset)

2005-10-07 Thread Martin Vermeer
On Fri, 2005-10-07 at 10:51 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Thu, 2005-10-06 at 10:39 +0300, Martin Vermeer wrote: > >> Not really too mysterious. > > Martin> Talking about mysterious, can anyone explain what > > Mar

Re: Crash on cursor movement around inset

2005-10-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> This looks like a biggie. Fortunately nothing to do with Martin> speed-up patch... Jean-Marc, how is your testing going ;-) About the speed-up patch? Since it seems to work and we have no obvious improvements to do right now, I

Re: selection_position_was_oldcursor_position (Re: Crash on cursor movement around inset)

2005-10-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Thu, 2005-10-06 at 10:39 +0300, Martin Vermeer wrote: >> Not really too mysterious. Martin> Talking about mysterious, can anyone explain what Martin> selection_position_was_oldcursor_position Martin> is for?

selection_position_was_oldcursor_position (Re: Crash on cursor movement around inset)

2005-10-06 Thread Martin Vermeer
On Thu, 2005-10-06 at 10:39 +0300, Martin Vermeer wrote: > Not really too mysterious. Talking about mysterious, can anyone explain what selection_position_was_oldcursor_position is for? What's wrong with just resetting the anchor unconditionally? - Martin signature.asc De

Re: Crash on cursor movement around inset

2005-10-06 Thread Martin Vermeer
On Wed, 2005-10-05 at 15:05 -0400, Bennett Helm wrote: > Here's a recipe for a crash with lyx-140 patch with Martin's speedup > patch (x.diff as of 9/29). > > Type some arbitrary text. Below this, create an inset in a paragraph > all by itself; set this paragraph to have no indentation. Place

Re: Crash on cursor movement around inset

2005-10-05 Thread Martin Vermeer
On Wed, Oct 05, 2005 at 03:05:55PM -0400, Bennett Helm wrote: > Here's a recipe for a crash with lyx-140 patch with Martin's speedup > patch (x.diff as of 9/29). > > Type some arbitrary text. Below this, create an inset in a paragraph > all by itself; set this paragraph to have no indentation.

Re: Crash on cursor movement around inset

2005-10-05 Thread Martin Vermeer
On Wed, Oct 05, 2005 at 03:05:55PM -0400, Bennett Helm wrote: > Here's a recipe for a crash with lyx-140 patch with Martin's speedup > patch (x.diff as of 9/29). Does this happen without the patch? > Type some arbitrary text. Below this, create an inset in a paragraph > all by itself; set th