Re: Crash on Fedora 23 on copying or cutting text

2015-09-14 Thread José Matos
On Sunday 13 September 2015 13:53:07 Richard Heck wrote: > For stable, too, then. > > rh FWIW I have updated Fedora lyx package with George's patch. The package is in updates-testing and it should be soon, in a week or so, be in updates. The updates is only required for Fedora 23 and rawhide ->

Re: Crash on Fedora 23 on copying or cutting text

2015-09-13 Thread Richard Heck
On 09/12/2015 08:32 PM, José Matos wrote: On Friday 11 September 2015 23:33:52 Georg Baum wrote: The attached patch fixes the crash. Shall I apply it? Georg Please do. :-) I can confirm that it solves all the crashes I had before (FWIW I am just testing 2.1.4). For stable, too, then. rh

Re: Crash on Fedora 23 on copying or cutting text

2015-09-13 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 12/09/15 13:58, Georg Baum a écrit : >> Jean-Marc Lasgouttes wrote: >> >>> I suspect a compiler bug. >> >> After further thinking about it I agree and reported it: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67557 >> The attached patch fixes the crash. Sha

Re: Crash on Fedora 23 on copying or cutting text

2015-09-12 Thread José Matos
On Friday 11 September 2015 23:33:52 Georg Baum wrote: > The attached patch fixes the crash. Shall I apply it? > > > Georg Please do. :-) I can confirm that it solves all the crashes I had before (FWIW I am just testing 2.1.4). Best regards, -- José Abílio

Re: Crash on Fedora 23 on copying or cutting text

2015-09-12 Thread Jean-Marc Lasgouttes
Le 12/09/15 13:58, Georg Baum a écrit : Jean-Marc Lasgouttes wrote: I suspect a compiler bug. After further thinking about it I agree and reported it: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67557 The attached patch fixes the crash. Shall I apply it? Sure, it makes the code cleaner a

Re: Crash on Fedora 23 on copying or cutting text

2015-09-12 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > I suspect a compiler bug. After further thinking about it I agree and reported it: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67557 >> The attached patch fixes the crash. Shall I apply it? > > Sure, it makes the code cleaner anyway. Did you try to run valgrind w

Re: Crash on Fedora 23 on copying or cutting text

2015-09-12 Thread Jean-Marc Lasgouttes
Le 11/09/15 23:33, Georg Baum a écrit : fontToStartTag() is a function that constructs a StartTag and returns it. Then, the copy constructor StartTag::StartTag() is called, constructing the FontTag object from the temporary StartTag object, and finally font_type_ is initialized. Calling a copy co

Re: Crash on Fedora 23 on copying or cutting text

2015-09-11 Thread Richard Heck
I think the patch is OK. I have no idea why it crashes. Richard On 09/11/2015 05:33 PM, Georg Baum wrote: Jean-Marc Lasgouttes wrote: The line of Paragraph.cpp which causes the crash reads: tagsToOpen.push_back(html::FontTag(html::FT_ROMAN)); I do not see how this could go wrong... Is it

Re: Crash on Fedora 23 on copying or cutting text

2015-09-11 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > The line of Paragraph.cpp which causes the crash reads: > tagsToOpen.push_back(html::FontTag(html::FT_ROMAN)); > > I do not see how this could go wrong... Is it a problem to push_back a > temp object in a container? Georg, any idea? Actually it has something to do w

Re: Crash on Fedora 23 on copying or cutting text

2015-09-10 Thread Richard Heck
On 09/09/2015 04:30 PM, Georg Baum wrote: Jean-Marc Lasgouttes wrote: The line of Paragraph.cpp which causes the crash reads: tagsToOpen.push_back(html::FontTag(html::FT_ROMAN)); I do not see how this could go wrong... Is it a problem to push_back a temp object in a container? Georg, any idea?

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > The line of Paragraph.cpp which causes the crash reads: > tagsToOpen.push_back(html::FontTag(html::FT_ROMAN)); > > I do not see how this could go wrong... Is it a problem to push_back a > temp object in a container? Georg, any idea? No, the temp object should not be

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread Cor Blom
Op 09-09-15 om 11:30 schreef José Matos: On Wednesday 09 September 2015 09:33:12 José Matos wrote: For me the crash is easily reproducible, it is enough to select some text and then to copy it or cut it, lyx always crashes. The attached file is a simple example where this happens. Select the

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2015 11:19, José Matos a écrit : On Wednesday 09 September 2015 10:56:25 Jean-Marc Lasgouttes wrote: Can you get a more explicit backtrace? JMarc I send it attached. Note that in this case I am using lyx-2.2dev from yesterday, compiled with qt-5.5 (not that it matters in this case).

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread José Matos
On Wednesday 09 September 2015 09:33:12 José Matos wrote: > > For me the crash is easily reproducible, it is enough to select some text and > then to copy it or cut it, lyx always crashes. The attached file is a simple example where this happens. Select the first frame copy it and lyx crashes,

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread José Matos
On Wednesday 09 September 2015 10:56:25 Jean-Marc Lasgouttes wrote: > Can you get a more explicit backtrace? > > JMarc I send it attached. Note that in this case I am using lyx-2.2dev from yesterday, compiled with qt-5.5 (not that it matters in this case). So the crash happens for both 2.1 and

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2015 10:54, José Matos a écrit : On Wednesday 09 September 2015 10:36:17 Jean-Marc Lasgouttes wrote: Hi José, Can you give valgrind a try? And send your config.log (to see whether new string implementation is correctly detected). JMarc I get this: ==12666== Invalid free() / delete

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2015 10:50, José Matos a écrit : On Wednesday 09 September 2015 10:36:17 Jean-Marc Lasgouttes wrote: Hi José, Can you give valgrind a try? And send your config.log (to see whether new string implementation is correctly detected). JMarc The config.log is available here: https://kojip

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread José Matos
On Wednesday 09 September 2015 10:36:17 Jean-Marc Lasgouttes wrote: > Hi José, > > Can you give valgrind a try? And send your config.log (to see whether > new string implementation is correctly detected). > > JMarc I get this: ==12666== Invalid free() / delete / delete[] / realloc() ==12666==

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread José Matos
On Wednesday 09 September 2015 10:36:17 Jean-Marc Lasgouttes wrote: > Hi José, > > Can you give valgrind a try? And send your config.log (to see whether > new string implementation is correctly detected). > > JMarc The config.log is available here: https://kojipkgs.fedoraproject.org//packages/l

Re: Crash on Fedora 23 on copying or cutting text

2015-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2015 10:33, José Matos a écrit : Hi, we got a report on Fedora about a crash for Fedora 23. (I am the initial reporter in case you wonder ;-) ) https://bugzilla.redhat.com/show_bug.cgi?id=1260976 The backtrace is available at https://bugzilla.redhat.com/attachment.cgi?id=10712