Re: Coverity Loop Issue

2017-01-16 Thread Tommaso Cucinotta
On 07/01/2017 18:16, Tommaso Cucinotta wrote: Let me do some test on master and double-check whether there's any regression when ignore-format is off. just a heads-up: couldn't run the autotests yet, there's some issue and key presses from the scripts can't reach the LyXwindow that remains th

Re: Coverity Loop Issue

2017-01-07 Thread Tommaso Cucinotta
On 07/01/2017 03:09, Richard Heck wrote: My question is: did you work out why this for() loop is here if it does not have any effect? sorry guys to chime in so late, according to the original comment from the very first patch below: // Try all possible regexp matches, until one that v

Re: Coverity Loop Issue

2017-01-06 Thread Richard Heck
On 01/06/2017 05:06 PM, Jean-Marc Lasgouttes wrote: > Le 18/12/2016 à 04:21, Richard Heck a écrit : >> JMarc, I think the attached patches take care of this. I broke it up so >> it was more obvious what was happening. The first patch takes care of >> the for-loop issue, and the others re-organize a

Re: Coverity Loop Issue

2017-01-06 Thread Jean-Marc Lasgouttes
Le 06/01/2017 à 23:06, Jean-Marc Lasgouttes a écrit : Le 18/12/2016 à 04:21, Richard Heck a écrit : JMarc, I think the attached patches take care of this. I broke it up so it was more obvious what was happening. The first patch takes care of the for-loop issue, and the others re-organize a bit t

Re: Coverity Loop Issue

2017-01-06 Thread Jean-Marc Lasgouttes
Le 18/12/2016 à 04:21, Richard Heck a écrit : JMarc, I think the attached patches take care of this. I broke it up so it was more obvious what was happening. The first patch takes care of the for-loop issue, and the others re-organize a bit to make the logic clearer. My question is: did you wor