Re: Comments on younes branch

2006-06-25 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Why is the assert commented out? | > @@ -1949,8 +1948,8 @@ | > BufferView * LyXFunc::view() const | > { | > - BOOST_ASSERT(owner); | > - return owner->view().get(); | > +//

Re: Comments on younes branch

2006-06-25 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: Why this change? For consistency reason with other macros. I don't care much. -#ifndef GUIVIEW_H -#define GUIVIEW_H +#ifndef GUI_VIEW_H +#define GUI_VIEW_H If to make the string unique, I would have prefered: QT4_GU

Re: Comments on younes branch

2006-06-25 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: Index: src/frontends/qt3/QtView.h === --- src/frontends/qt3/QtView.h (.../svn+ssh://svn.lyx.org/lyx/lyx-devel/trunk/s rc) (revision 14200) +++ src/fronte

Re: Comments on younes branch

2006-06-25 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Why is the assert commented out? | > @@ -1949,8 +1948,8 @@ | > BufferView * LyXFunc::view() const | > { | > - BOOST_ASSERT(owner); | > - return owner->view().get(); | > +// BOOST_ASSERT(owner); | > +

Re: Comments on younes branch

2006-06-25 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Why is the assert commented out? @@ -1949,8 +1948,8 @@ BufferView * LyXFunc::view() const { - BOOST_ASSERT(owner); - return owner->view().get(); +// BOOST_ASSERT(owner); + return owner->view(); IIRC correctly this was because it was accessed

Re: Comments on younes branch

2006-06-24 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: Why this change? Index: src/frontends/qt4/GuiView.h === --- src/frontends/qt4/GuiView.h (.../svn+ssh://svn.lyx.org/lyx/lyx-devel/trunk/s rc) (revision 14200) +++ src/frontends/qt4/G

Re: Comments on younes branch

2006-06-24 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: Index: src/frontends/qt3/QtView.h === --- src/frontends/qt3/QtView.h (.../svn+ssh://svn.lyx.org/lyx/lyx-devel/trunk/s rc) (revision 14200) +++ src/frontends/qt3/QtView.h (.../src)