Re: Closing views versus closing buffers

2012-09-28 Thread Tommaso Cucinotta
On 26/09/12 02:16, Tommaso Cucinotta wrote: On 17/09/12 08:57, Rainer M Krug wrote: Agreed - that would make it clear, that it is simply "a new niew of the same document in the same LyX instance" and not a new LyX instance. Cheers, Rainer Hi, please, find attached the take 2 of this patch.

Re: Re: Closing views versus closing buffers

2012-09-26 Thread Kornel Benko
Am Mittwoch, 26. September 2012 um 02:16:34, schrieb Tommaso Cucinotta > > On Ubuntu, the File->Close (buffer) menu gets automagically tied to > Ctrl+F4, I don't know why > Because of use of "cua.bind"? I use emacs.bind and it is not tied Ctrl+F4. Kornel signature.asc Description: T

Re: Closing views versus closing buffers

2012-09-25 Thread Tommaso Cucinotta
On 17/09/12 08:57, Rainer M Krug wrote: Agreed - that would make it clear, that it is simply "a new niew of the same document in the same LyX instance" and not a new LyX instance. Cheers, Rainer Hi, please, find attached the take 2 of this patch. Changes: -) LFUN renamed to "view-close" -)

Re: Closing views versus closing buffers

2012-09-17 Thread Pavel Sanda
Tommaso Cucinotta wrote: >> Few technical things: >> - lfun naming should be object-operation, not operation-object > > I was "inspired" by close-tab-group, which could be renamed as > tab-group-close, to respect this convention. Feel free to fix it (cf. "NAMING RULES FOR USER-COMMANDS" in lyxact

Re: Closing views versus closing buffers

2012-09-17 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17/09/12 11:41, Jürgen Spitzmüller wrote: > Rainer M Krug wrote: >> OK - this makes sense, but why not close the master if one is working only >> in the child >> document? > > Because this would close the master and all its children. And I want to

Re: Closing views versus closing buffers

2012-09-17 Thread Jürgen Spitzmüller
Rainer M Krug wrote: > OK - this makes sense, but why not close the master if one is working only > in the child document? Because this would close the master and all its children. And I want to keep the master buffer active (to use master-buffer-view, for instance). Jürgen

Re: Closing views versus closing buffers

2012-09-17 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17/09/12 10:10, Jürgen Spitzmüller wrote: > Rainer M Krug wrote: >> But anyway: is there a real use-case or need for the hide function? > > Yes: You work with a multi-part document, and you want to hide the master. OK - this makes sense, but why n

Re: Closing views versus closing buffers

2012-09-17 Thread Jean-Marc Lasgouttes
Le 17/09/2012 08:55, Tommaso Cucinotta a écrit : On 16/09/12 14:19, Pavel Sanda wrote: No strong opinion about the change itself. Few technical things: - lfun naming should be object-operation, not operation-object I was "inspired" by close-tab-group, which could be renamed as tab-group-close

Re: Re: Closing views versus closing buffers

2012-09-17 Thread Kornel Benko
Am Montag, 17. September 2012 um 08:00:32, schrieb Tommaso Cucinotta > On 16/09/12 16:55, Pavel Sanda wrote: > > Kornel Benko wrote: > >> What I would like is hiding even if it were the last WA. > > So we are at the usual problem that everyone has different opinion how the > > UI should work :)

Re: Closing views versus closing buffers

2012-09-17 Thread Jürgen Spitzmüller
Rainer M Krug wrote: > But anyway: is there a real use-case or need for the hide function? Yes: You work with a multi-part document, and you want to hide the master. Jürgen

Re: Closing views versus closing buffers

2012-09-17 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/09/12 15:05, Pavel Sanda wrote: > Tommaso Cucinotta wrote: >> Also, I just noticed that the "Close Tab" action available when >> right-clicking on a tab name, >> actually closes the buffer, along with all tabs in any view possibly >> associated

Re: Closing views versus closing buffers

2012-09-17 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/09/12 14:55, Pavel Sanda wrote: > Tommaso Cucinotta wrote: >> On 13/09/12 01:07, Pavel Sanda wrote: >>> Richard Heck wrote: > Shouldn't we close the view only, >>> I thought thats why we have "hide" function distinguished from close. >> >> T

Re: Closing views versus closing buffers

2012-09-17 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 15/09/12 12:26, Tommaso Cucinotta wrote: > On 13/09/12 10:29, Rainer M Krug wrote: > >> What about a popup box, asking: >> >> - Do you want to close All windows / views of this document >> or only this >> one? >> >> All / Only T

Re: Closing views versus closing buffers

2012-09-17 Thread Tommaso Cucinotta
On 16/09/12 16:55, Pavel Sanda wrote: Kornel Benko wrote: What I would like is hiding even if it were the last WA. So we are at the usual problem that everyone has different opinion how the UI should work :) P However, this might be fixable as someone suggested in a prior message: close the

Re: Closing views versus closing buffers

2012-09-16 Thread Tommaso Cucinotta
On 16/09/12 14:19, Pavel Sanda wrote: No strong opinion about the change itself. Few technical things: - lfun naming should be object-operation, not operation-object I was "inspired" by close-tab-group, which could be renamed as tab-group-close, to respect this convention. - close tab does n

Re: Re: Re: Closing views versus closing buffers

2012-09-16 Thread Pavel Sanda
Kornel Benko wrote: > What I would like is hiding even if it were the last WA. So we are at the usual problem that everyone has different opinion how the UI should work :) P

Re: Re: Re: Closing views versus closing buffers

2012-09-16 Thread Kornel Benko
Am Sonntag, 16. September 2012 um 16:19:50, schrieb Pavel Sanda > Kornel Benko wrote: > > why not "tab-hide" ? For the user, it should do exact this. > > Because it also closes the buffer in certain cases. It's hybrid > between hide and close. P Sure. We are talking about change in function han

Re: Re: Closing views versus closing buffers

2012-09-16 Thread Pavel Sanda
Kornel Benko wrote: > why not "tab-hide" ? For the user, it should do exact this. Because it also closes the buffer in certain cases. It's hybrid between hide and close. P

Re: Re: Closing views versus closing buffers

2012-09-16 Thread Kornel Benko
Am Sonntag, 16. September 2012 um 15:19:32, schrieb Pavel Sanda > Tommaso Cucinotta wrote: > > Any comment is welcome. > > No strong opinion about the change itself. > > Few technical things: > - lfun naming should be object-operation, not operation-object > - new line after first line of commit

Re: Closing views versus closing buffers

2012-09-16 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Any comment is welcome. No strong opinion about the change itself. Few technical things: - lfun naming should be object-operation, not operation-object - new line after first line of commit message is missing (git feature, we should use first line as a summary now) -

Re: Closing views versus closing buffers

2012-09-16 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Also, I just noticed that the "Close Tab" action available when > right-clicking on a tab name, actually closes the buffer, along with all > tabs in any view possibly associated to it. This behavior seems also quite > wrong, in my opinion. You are right, the current f

Re: Closing views versus closing buffers

2012-09-16 Thread Pavel Sanda
Tommaso Cucinotta wrote: > On 13/09/12 01:07, Pavel Sanda wrote: >> Richard Heck wrote: Shouldn't we close the view only, >> I thought thats why we have "hide" function distinguished from close. > > The problem with hiding is that the buffer is not automatically closed > after the last view h

Re: Closing views versus closing buffers

2012-09-15 Thread Tommaso Cucinotta
On 11/09/12 20:42, Tommaso Cucinotta wrote: I just noticed that when you type C-w, LyX closes the buffer, along with all views. Also, if you have a split window and multiple tabbed views on both splits, pushing the "X" button on one of the tabs triggers a close of the buffer, so also the view

Re: Re: Closing views versus closing buffers

2012-09-15 Thread Kornel Benko
Am Samstag, 15. September 2012 um 11:29:56, schrieb Tommaso Cucinotta > On 13/09/12 01:07, Pavel Sanda wrote: > > Richard Heck wrote: > >>> Shouldn't we close the view only, > > I thought thats why we have "hide" function distinguished from close. > > The problem with hiding is that the buffer i

Re: Closing views versus closing buffers

2012-09-15 Thread Tommaso Cucinotta
On 13/09/12 01:07, Pavel Sanda wrote: Richard Heck wrote: Shouldn't we close the view only, I thought thats why we have "hide" function distinguished from close. The problem with hiding is that the buffer is not automatically closed after the last view has been hidden. On the other hand, clo

Re: Closing views versus closing buffers

2012-09-15 Thread Tommaso Cucinotta
On 13/09/12 10:29, Rainer M Krug wrote: What about a popup box, asking: - Do you want to close All windows / views of this document or only this one? All / Only This / Cancel [ ] Do this from now on automatically - By doing this (if more then one window of a

Re: Closing views versus closing buffers

2012-09-15 Thread Tommaso Cucinotta
On 12/09/12 22:59, Richard Heck wrote: On 09/11/2012 03:42 PM, Tommaso Cucinotta wrote: I just noticed that when you type C-w, LyX closes the buffer, along with all views. Also, if you have a split window and multiple tabbed views on both splits, pushing the "X" button on one of the tabs trig

Re: Closing views versus closing buffers

2012-09-14 Thread Pavel Sanda
Rainer M Krug wrote: > >> I thought thats why we have "hide" function distinguished from close. > > I must admit, that one is quite hidden - and it does not seem to close the > view, but only hides it > - - it is under the "hidden" submenu under "View". It used to be directly in tab bar, but the

Re: Closing views versus closing buffers

2012-09-13 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13/09/12 10:32, Jean-Marc Lasgouttes wrote: > Le 13/09/2012 02:07, Pavel Sanda a écrit : >> Richard Heck wrote: Shouldn't we close the view only, What about a popup box, asking: - Do you want to close All windows / views of t

Re: Closing views versus closing buffers

2012-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2012 02:07, Pavel Sanda a écrit : Richard Heck wrote: Shouldn't we close the view only, I thought thats why we have "hide" function distinguished from close. I think this view vs buffer stuff is becoming too complicated to be really useful. Example: on a mac (use views instead of

Re: Closing views versus closing buffers

2012-09-12 Thread Pavel Sanda
Richard Heck wrote: >> Shouldn't we close the view only, I thought thats why we have "hide" function distinguished from close. Pavel

Re: Closing views versus closing buffers

2012-09-12 Thread Richard Heck
On 09/11/2012 03:42 PM, Tommaso Cucinotta wrote: I just noticed that when you type C-w, LyX closes the buffer, along with all views. Also, if you have a split window and multiple tabbed views on both splits, pushing the "X" button on one of the tabs triggers a close of the buffer, so also the