Georg Baum wrote:
On Saturday 30 December 2006 15:43, Abdelrazak Younes wrote:
I think this is old, disabled, bidi code. Don't touch it if you don't
know what you're doing. Georg, do you know something about this?
Not really. If you want to fix this without understanding comment out the
whole
Georg Baum wrote:
On Saturday 30 December 2006 15:50, Abdelrazak Younes wrote:
Ah.. OK, then commit and I'll take care of that afterward.
There are some more unused vaiables. Did you forget to use right_margin in
getColumnNearX, or can it be removed?
I used it at some point in the transiti
On Saturday 30 December 2006 15:50, Abdelrazak Younes wrote:
> Ah.. OK, then commit and I'll take care of that afterward.
There are some more unused vaiables. Did you forget to use right_margin in
getColumnNearX, or can it be removed?
Georg
Index: src/text2.C
==
On Saturday 30 December 2006 12:49, Abdelrazak Younes wrote:
> Kornel Benko wrote:
> > Hi,
> > last svn1.5 version, binding ...
>
> I forgot to remove the duplicates in text.C, MSVC did not complain...
> This is fixed now.
MSVC was right. Kornel must have a buggy compiler, it is not handling
anon
On Saturday 30 December 2006 15:43, Abdelrazak Younes wrote:
> I think this is old, disabled, bidi code. Don't touch it if you don't
> know what you're doing. Georg, do you know something about this?
Not really. If you want to fix this without understanding comment out the
whole if statement with
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Edwin Leuven wrote:
Abdelrazak Younes wrote:
I am sanitizing the DEPM so the returned boolean is going to
disappear soon, don't touch this code please.
Ditto.
i commented them out because atm these are handled as errors...
Ah.. OK, then commit
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Edwin Leuven wrote:
Abdelrazak Younes wrote:
I am sanitizing the DEPM so the returned boolean is going to
disappear soon, don't touch this code please.
Ditto.
i commented them out because atm these are handled as errors...
Ah.. OK, then commit
Abdelrazak Younes wrote:
Edwin Leuven wrote:
Abdelrazak Younes wrote:
I am sanitizing the DEPM so the returned boolean is going to
disappear soon, don't touch this code please.
Ditto.
i commented them out because atm these are handled as errors...
Ah.. OK, then commit and I'll take care o
Edwin Leuven wrote:
Abdelrazak Younes wrote:
I am sanitizing the DEPM so the returned boolean is going to disappear
soon, don't touch this code please.
Ditto.
i commented them out because atm these are handled as errors...
Ah.. OK, then commit and I'll take care of that afterward.
Abdel.
Abdelrazak Younes wrote:
I am sanitizing the DEPM so the returned boolean is going to disappear
soon, don't touch this code please.
Ditto.
i commented them out because atm these are handled as errors...
Edwin Leuven wrote:
> attached some more unused stuff
>
> one thing: msvc complained about boundary below not being referenced.
> removing the false in the if got rid of the warning. am not sure if i
> understand what it was doing there (and didn't try to grasp the if
> either) ...
>
When you th
Edwin Leuven wrote:
attached some more unused stuff
one thing: msvc complained about boundary below not being referenced.
removing the false in the if got rid of the warning. am not sure if i
understand what it was doing there (and didn't try to grasp the if
either) ...
I think this is old,
attached some more unused stuff
one thing: msvc complained about boundary below not being referenced.
removing the false in the if got rid of the warning. am not sure if i
understand what it was doing there (and didn't try to grasp the if
either) ...
@@ -1073,7 +1069,7 @@
bo
Peter Kümmel wrote:
Abdelrazak Younes wrote:
Edwin Leuven wrote:
could it be that the attached are trailin... ?
Yes, you're right, please commit. It's a pity that MSVC doesn't detect
unused variables...
Because you compile with warning level 3.
Now you can't forget it :)
I've marked the rel
Abdelrazak Younes wrote:
> Edwin Leuven wrote:
>> could it be that the attached are trailin... ?
>
> Yes, you're right, please commit. It's a pity that MSVC doesn't detect
> unused variables...
Because you compile with warning level 3.
Now you can't forget it :)
I've marked the relevant warnings
Edwin Leuven wrote:
> Abdelrazak Younes wrote:
>> Edwin Leuven wrote:
>>> could it be that the attached are trailin... ?
>>
>> Yes, you're right, please commit. It's a pity that MSVC doesn't detect
>> unused variables...
>
> it is in.
>
> msvc complains here. you probably turned off the warnings.
Abdelrazak Younes wrote:
Edwin Leuven wrote:
could it be that the attached are trailin... ?
Yes, you're right, please commit. It's a pity that MSVC doesn't detect
unused variables...
it is in.
msvc complains here. you probably turned off the warnings. the only
thing i do here is:
cmake
Edwin Leuven wrote:
could it be that the attached are trailin... ?
Yes, you're right, please commit. It's a pity that MSVC doesn't detect
unused variables...
Abdel.
could it be that the attached are trailin... ?
Index: text.C
===
--- text.C (revision 16438)
+++ text.C (working copy)
@@ -1798,8 +1798,6 @@
if (pm.rows().empty())
return 0;
- int max_width =
Am Samstag, 30. Dezember 2006 12:49 schrieb Abdelrazak Younes:
> I forgot to remove the duplicates in text.C, MSVC did not complain...
> This is fixed now.
As usual, very fast :)
Confirmed.
Kornel
--
Kornel Benko
[EMAIL PROTECTED]
pgpCNs3XLFy5A.pgp
Description: PGP signature
Kornel Benko wrote:
Hi,
last svn1.5 version, binding ...
I forgot to remove the duplicates in text.C, MSVC did not complain...
This is fixed now.
Thanks for the report,
Abdel.
21 matches
Mail list logo
