Re: Add safety measures when saving a file

2010-03-26 Thread Pavel Sanda
Richard Heck wrote: > Looks good to me. thanks for comments. pavel

Re: Add safety measures when saving a file

2010-03-26 Thread rgheck
On 03/26/2010 02:12 PM, Pavel Sanda wrote: Richard Heck wrote: wouldnt be better this way // Saving failed, so backup is not backup if (madeBackup) backupName.moveTo(d->filename); +d->filename.copyTo(d->backupName);

Re: Add safety measures when saving a file

2010-03-26 Thread Pavel Sanda
Richard Heck wrote: >> wouldnt be better this way >> // Saving failed, so backup is not backup >> if (madeBackup) >> backupName.moveTo(d->filename); >> +d->filename.copyTo(d->backupName); >> >> >> > I'm a bit puzzled here. Why c

Re: Add safety measures when saving a file

2010-03-26 Thread rgheck
On 03/25/2010 08:07 PM, Pavel Sanda wrote: hi, this is not fixing the root of #6587 but at least we add some safety measures. since its touching sensitive area of code, i'd like to ask for review before committing. I read the thread on the bug. This is weird and annoying. From what I can t