Re: [pathch] fix bug 1988

2007-02-01 Thread Uwe Stöhr
> I believe that this is more robust: It would also catch lyxlines that are > embedded in a paragraph (makes not much sense, but is possible to do), and > it would not change the size of any text that may follow after the > lyxline. That's also assured with my version, it works with consecutive \

Re: [pathch] fix bug 1988

2007-02-01 Thread Abdelrazak Younes
Georg Baum wrote: Am Mittwoch, 31. Januar 2007 22:11 schrieb Uwe Stöhr: >> What? The patch was wrong. It should have created a new format, and a >> description in development/FORMAT. I added a description to the FORMAT file now. (the change from 256 to 257 made by Abdel yesterday is not ex

Re: [pathch] fix bug 1988

2007-01-31 Thread Uwe Stöhr
>> What? The patch was wrong. It should have created a new format, and a >> description in development/FORMAT. I added a description to the FORMAT file now. (the change from 256 to 257 made by Abdel yesterday is not explained there) As you know I'm new in this field: Why was it necessary to inc

Re: [pathch] fix bug 1988

2007-01-31 Thread Georg Baum
Am Mittwoch, 31. Januar 2007 22:11 schrieb Uwe Stöhr: > >> What? The patch was wrong. It should have created a new format, and a > >> description in development/FORMAT. > > I added a description to the FORMAT file now. (the change from 256 to 257 made by Abdel yesterday is > not explained ther

Re: [pathch] fix bug 1988

2007-01-31 Thread José Matos
On Wednesday 31 January 2007 9:12:34 am Georg Baum wrote: > What? The patch was wrong. It should have created a new format, and a > description in development/FORMAT. Honestly I thought that the patch did that, that was I only looked into the lyx2lyx convertion function. My mistake. :-( > I am

Re: [pathch] fix bug 1988

2007-01-31 Thread Georg Baum
José Matos wrote: > On Tuesday 30 January 2007 12:52:58 am Uwe Stöhr wrote: >> OK, attached is an updated patch that does this in lyx2lyx. OK? >> (I tested it very carefully and it works, but note that this is my first >> conatct with python so I may not follow the formatting guidelines.) > > T

Re: [pathch] fix bug 1988

2007-01-30 Thread Uwe Stöhr
> If it works please commit it, a code review shows a clear logic, so any > remaining bug should be easy to catch. Done, I committed it with better documentation: http://www.lyx.org/trac/changeset/16962 regards Uwe

Re: [pathch] fix bug 1988

2007-01-30 Thread José Matos
On Tuesday 30 January 2007 12:52:58 am Uwe Stöhr wrote: > OK, attached is an updated patch that does this in lyx2lyx. OK? > (I tested it very carefully and it works, but note that this is my first > conatct with python so I may not follow the formatting guidelines.) The code is old style, as mos

Re: [pathch] fix bug 1988

2007-01-29 Thread Uwe Stöhr
> Since the > old definition did not honour the font size lyx2lyx needs to change the > font of all existing \lyxlines to normal size. This is not difficult to do, > and preserves the formatting of existing documents. If users don't like > that they can still reset the font afterwards. OK, attach

Re: [pathch] fix bug 1988

2007-01-29 Thread Georg Baum
Uwe Stöhr wrote: > I mean Herbert is a real LaTeX guru and I'm sure that his sulution is > stable. Btw. I'm using this code in my documents now a while and never got > problems anymore with \lyxlines. Sure, nobody questions that the new definition is far better than the old one. > Where's a form

Re: [pathch] fix bug 1988

2007-01-29 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: Uwe> The current \lyxline definition is buggy. The attached patch Uwe> changes it to the definition Herbert Voss proposed. OK? I do not think we can use this patch like that: 1/ if we remove the 1ex spacing on both sides, lyx2lyx should re-add them separately.

Re: [pathch] fix bug 1988

2007-01-29 Thread Jean-Marc Lasgouttes
> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes: Uwe> The current \lyxline definition is buggy. The attached patch Uwe> changes it to the definition Herbert Voss proposed. OK? I do not think we can use this patch like that: 1/ if we remove the 1ex spacing on both sides, lyx2lyx should re-add