Re: [patch] support to set box features in the box dialog

Am 16.05.2015 um 23:53 schrieb Pavel Sanda: thickness_string contains the thickness parameter. It contains e.g. "5cm" if the frame thickness is 5cm. so you could just use thickness_string==defaultThick ? p Thanks Pavel, your are totally right. I have done this now. regards Uwe

Re: [patch] support to set box features in the box dialog

Uwe Stöhr wrote: > Am 13.05.2015 um 09:08 schrieb Pavel Sanda: > >> You are repeatably uing this contruct: >> thickness_string.find(defaultThick) != string::npos >> >> What is thickness_string and similar supposed to contain? > > thickness_string contains the thickness parameter. It contains e.g. "

Re: [patch] support to set box features in the box dialog

Am 11.05.2015 um 21:07 schrieb Georg Baum: Reverting files is very useful, for example when you collaborate with a colleague who does not have the latest version. I started a separate thread about this. regards Uwe

Re: [patch] support to set box features in the box dialog

Am 13.05.2015 um 09:08 schrieb Pavel Sanda: You are repeatably uing this contruct: thickness_string.find(defaultThick) != string::npos What is thickness_string and similar supposed to contain? thickness_string contains the thickness parameter. It contains e.g. "5cm" if the frame thickness is

Re: [patch] support to set box features in the box dialog

Uwe Stöhr wrote: > Am 11.05.2015 um 17:32 schrieb Pavel Sanda: > >> Could you put the hardcoded values like "0.4pt", "3pt" into some const >> variable and use it instead >> of spilling these strings all over the place? > > Thanks for the hint. I have done this now and also improved the code to >

Re: [patch] support to set box features in the box dialog

Am 11.05.2015 um 17:32 schrieb Pavel Sanda: Could you put the hardcoded values like "0.4pt", "3pt" into some const variable and use it instead of spilling these strings all over the place? Thanks for the hint. I have done this now and also improved the code to shorten it and to assure a clea

Re: [patch] support to set box features in the box dialog

On Sat, May 9, 2015 at 11:17 PM, Scott Kostyshak wrote: > On Sat, May 9, 2015 at 9:04 PM, Uwe Stöhr wrote: > >> (I am aware that tex2lyx is still missing - I will do this before >> committing.) > > Please also check that the tex2lyx tests pass after your changes and > before committing. For more

Re: [patch] support to set box features in the box dialog

Uwe Stöhr wrote: > Am 10.05.2015 um 16:52 schrieb Uwe Stöhr: > >> If you insist in having the new feature not to be truncated, I have to >> output ERT. > > The attached better patch does this. It also addresses now tex2lyx. > >> In general we should think about dropping the support to revert >>

Re: Re: [patch] support to set box features in the box dialog

On Monday 11 May 2015 08:32:39 Pavel Sanda wrote: > Could you put the hardcoded values like "0.4pt", "3pt" into some const > variable and use it instead > of spilling these strings all over the place? > > Pavel The same advice applies to the lyx2lyx code. It becomes easier to maintain that way.

Re: [patch] support to set box features in the box dialog

Uwe Stöhr wrote: > diff --git a/src/insets/InsetBox.cpp b/src/insets/InsetBox.cpp > index ddb1dce..e6e873b 100644 > --- a/src/insets/InsetBox.cpp > +++ b/src/insets/InsetBox.cpp > @@ -306,17 +319,25 @@ void InsetBox::latex(otexstream & os, OutputParams > const & runparams) const > case Frame

Re: [patch] support to set box features in the box dialog

On 05/10/2015 06:41 PM, Uwe Stöhr wrote: Am 10.05.2015 um 16:52 schrieb Uwe Stöhr: If you insist in having the new feature not to be truncated, I have to output ERT. The attached better patch does this. It also addresses now tex2lyx. I agree that this is messy. But as you said in a differen

Re: [patch] support to set box features in the box dialog

Am 10.05.2015 um 16:52 schrieb Uwe Stöhr: If you insist in having the new feature not to be truncated, I have to output ERT. The attached better patch does this. It also addresses now tex2lyx. In general we should think about dropping the support to revert documents to older versions of LyX.

Re: [patch] support to set box features in the box dialog

Am 10.05.2015 um 15:30 schrieb Richard Heck: also seems wrong. The setting for thickness is just disappearing. I gather that, in some sense, that may be the only option, other than producing ERT for the entire box. But the document will not compile the same way, right? That is a fundamental de

Re: [patch] support to set box features in the box dialog

Am 10.05.2015 um 15:28 schrieb Richard Heck: I see that you explicitly set default values for some of these parameters, e.g.: +def convert_BoxFeatures(document): +" adds new box features " + +i = 0 +while True: +i = find_token(document.body, "height_special", i) +if

Re: [patch] support to set box features in the box dialog

Am 10.05.2015 um 05:17 schrieb Scott Kostyshak: I like patches that solve multiple bugs. Thanks, attached is a better patch that also fixes the unnecessary addition of \noindent for boxed in non-indent documents. regards Uwe development/FORMAT| 8 + lib/lyx2lyx/LyX.py

Re: [patch] support to set box features in the box dialog

PS This: +def revert_BoxFeatures(document): +" deletes new box features " + +i = 0 +while True: +i = find_token(document.body, "height_special", i) +if i == -1: +return +del document.body[i+1:i+4] +i = i + 1 also seems wrong. The setting f

Re: [patch] support to set box features in the box dialog

On 05/09/2015 09:04 PM, Uwe Stöhr wrote: Dear LyXers, attached is a patch that - redesigns the box dialog (better logic and necessary to expand it with features) - adds support to change the line thickness, box separation and shadow size (fixes bug #2598) - makes it possible to set a horizont

Re: [patch] support to set box features in the box dialog

On Sat, May 9, 2015 at 9:04 PM, Uwe Stöhr wrote: > (I am aware that tex2lyx is still missing - I will do this before > committing.) Please also check that the tex2lyx tests pass after your changes and before committing. For more information, see the section "How to update the file format number