Re: [patch] missing update

2005-05-06 Thread Andre Poenitz
On Fri, May 06, 2005 at 10:55:16AM +0100, Angus Leeming wrote: > Juergen Spitzmueller wrote: > > > In LyXFunc::dispatch, case LFUN_INSET_APPLY, there's an update call > > missing. You see it when you apply changes from an inset dialog. You have > > to do some keyboard action until the changes get

Re: [patch] missing update

2005-05-06 Thread Andre Poenitz
On Fri, May 06, 2005 at 11:55:29AM +0200, Juergen Spitzmueller wrote: > In LyXFunc::dispatch, case LFUN_INSET_APPLY, there's an update call missing. > You see it when you apply changes from an inset dialog. You have to do some > keyboard action until the changes get visible. > > The attached pat

Re: [patch] missing update

2005-05-06 Thread Juergen Spitzmueller
Georg Baum wrote: > I think that Jürgens patch is fine, I would however add a comment stating > that in an ideal world 'update' would be set by the inset. I did so and committed. Jürgen

Re: [patch] missing update

2005-05-06 Thread Georg Baum
Angus Leeming wrote: > I'm not saying it's wrong, but I note that 'update' is specified in very > few places in this function. Do all insets change there visible appearance > on LFUN_INSET_APPLY or should this 'update' flag be set by indvidual > insets. > > Just thinking out aloud. In theory not

Re: [patch] missing update

2005-05-06 Thread Angus Leeming
Juergen Spitzmueller wrote: > In LyXFunc::dispatch, case LFUN_INSET_APPLY, there's an update call > missing. You see it when you apply changes from an inset dialog. You have > to do some keyboard action until the changes get visible. > > The attached patch adds the update call. > > OK? > > Jürg