> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
Andre> Inset Cell Paragraph Chars or Insets Cell Paragraph ...
Andre> is the target structureo of IU. It's pretty much the thing
Andre> that's currently used (with an 'implicit' single paragraph per
Andre> cell in mathed and an 'implicit'
On Mon, Nov 14, 2005 at 11:00:08AM +0100, Georg Baum wrote:
> Juergen Spitzmueller wrote:
>
> > Jean-Marc Lasgouttes wrote:
> >> The problem is probably (as in bugs 1952/53) that there is no way when
> >> the cursor is in a tabular (top.inset() is the insettabular) to access
> >> the insettext its
Juergen Spitzmueller wrote:
> Georg Baum wrote:
>> Do you have a test case where this is a problem? At the moment I can't
>> see one.
>
> - Make a fixed width tabular cell
> - chose a non-standard layout (e.g. itemize)
> - reset tabular cell to non-fixed width
> - (the layout combo is correctly g
Georg Baum wrote:
> > Yes, that's true. The old code was broken as well. And that seems to be
>
> the
>
> > reason why forceDefaultParagraph does not force Standard paragraphs in
>
> the
>
> > output of tabulars (this is triggered by the Paragraph code and seems to
> > work for ERT).
>
> Do you hav
Am Dienstag, 15. November 2005 16:34 schrieb Juergen Spitzmueller:
> Yes, that's true. The old code was broken as well. And that seems to be
the
> reason why forceDefaultParagraph does not force Standard paragraphs in
the
> output of tabulars (this is triggered by the Paragraph code and seems to
Jean-Marc Lasgouttes wrote:
> >> The idea looks good to me. Does it mean that you are going to get
> >> rid of InsetBase::forceDefaultParagraph too?
>
> Georg> That would be nice, but I don't see how it can be done. It is
> Georg> needed in LyXText::dispatch and LyXFunc::getStatus. Whatever we
> Ge
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Jean-Marc Lasgouttes wrote:
>> The idea looks good to me. Does it mean that you are going to get
>> rid of InsetBase::forceDefaultParagraph too?
Georg> That would be nice, but I don't see how it can be done. It is
Georg> needed in LyX
Jean-Marc Lasgouttes wrote:
> The idea looks good to me. Does it mean that you are going to get rid
> of InsetBase::forceDefaultParagraph too?
That would be nice, but I don't see how it can be done. It is needed in
LyXText::dispatch and LyXFunc::getStatus.
Whatever we do here, I think that Jürgen
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> With the problem that this cached information gets easily
Georg> outdated. What about the following: Add a
Georg> forceDefaultParagraphs flag to Outputparams and use that
Georg> instead of Paragraph::forceDefault? The patch is not comp
On Wednesday 16 November 2005 09:47, Georg Baum wrote:
> With the problem that this cached information gets easily outdated. What
> about the following: Add a forceDefaultParagraphs flag to Outputparams and
> use that instead of Paragraph::forceDefault? The patch is not complete (ERT
> is missing),
Juergen Spitzmueller wrote:
> Yes, that's true. The old code was broken as well. And that seems to be
> the reason why forceDefaultParagraph does not force Standard paragraphs in
> the output of tabulars (this is triggered by the Paragraph code and seems
> to work for ERT).
> Basically, we'd have
Jean-Marc Lasgouttes wrote:
> Juergen> Looks much nicer :-)
>
> Indeed. If it works to your liking, please apply it.
OK, thanks.
> Juergen> I wonder if passing 0 from
> Juergen> Paragraph::forceDefaultParagraphs() is always correct,
> Juergen> though.
>
> I think it is equivalent to what we had
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Looks much nicer :-)
Indeed. If it works to your liking, please apply it.
Juergen> I wonder if passing 0 from
Juergen> Paragraph::forceDefaultParagraphs() is always correct,
Juergen> though.
I think it is equivalent t
Jean-Marc Lasgouttes wrote:
> What about redefining as
>
> virtual bool forceDefaultParagraphs(idx_type cell =0)
>
> Paragraph::forceDefaultParagraph would pass 0 (or no value), the
> others would use the cursor.
Looks much nicer :-)
I wonder if passing 0 from Paragraph::forceDefaultParagraphs() i
Juergen Spitzmueller wrote:
> Is it worth it to add the argument for documentation purposes?
The argument is already there. Do you mean to name it? IMHO it is worth it.
> Attached is a patch with some mor FIXME's and the proposed documentation
> (without having added the argument).
>
> Would th
Jean-Marc Lasgouttes wrote:
> And the parameter passed to the method seems bogus to me. It seems to
> be always like
> inset.forceDefaultParagraphs(&inset)
>
> The only case that is different is with insettabular, it seems. This
> does not make sense...
It makes sense in so far as the paramete
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Georg Baum wrote:
>> I see. I would also document the argument of forceDefaultParagraphs
>> in insetbase.h so that misunderstandings like in the current code
>> do not longer happen:
>>
>> /// if this inset has paragraph
Georg Baum wrote:
> I see. I would also document the argument of forceDefaultParagraphs in
> insetbase.h so that misunderstandings like in the current code do not
> longer happen:
>
> /// if this inset has paragraphs should they be output all as default
> /// paragraphs with "Standard" layout?
> //
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> I see. I would also document the argument of
Georg> forceDefaultParagraphs in insetbase.h so that misunderstandings
Georg> like in the current code do not longer happen:
Georg> /// if this inset has paragraphs should they be output al
Juergen Spitzmueller wrote:
> Jean-Marc Lasgouttes wrote:
>> The problem is probably (as in bugs 1952/53) that there is no way when
>> the cursor is in a tabular (top.inset() is the insettabular) to access
>> the insettext itself (the cell). InsetTabular suffers from some
>> personality disorder:
Jean-Marc Lasgouttes wrote:
> What about redefining as
>
> virtual bool forceDefaultParagraphs(idx_type cell =0)
>
> Paragraph::forceDefaultParagraph would pass 0 (or no value), the
> others would use the cursor.
>
> Considering the low number of instance of this method, it seems both
> easy and co
Jean-Marc Lasgouttes wrote:
> The problem is probably (as in bugs 1952/53) that there is no way when
> the cursor is in a tabular (top.inset() is the insettabular) to access
> the insettext itself (the cell). InsetTabular suffers from some
> personality disorder: it is a tabular from the outside, b
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Am Sonntag, 13. November 2005 13:01 schrieb Juergen
Georg> Spitzmueller:
>> The attached patch reimplements setDefaultParagraphs in
>> insettabular, as described in bug 1953. However, the paragraph
>> merging problem described
Georg> t
Georg Baum wrote:
> I think the code would be clearer without the tabular special casing in
> LyXText::dispatch() and LyXFunc::getStatus() and the new code in
> InsetTabular::forceDefaultParagraphs() instead. Does that not work?
I don't have access to the cursor there :-(
Jürgen
Am Sonntag, 13. November 2005 13:01 schrieb Juergen Spitzmueller:
> The attached patch reimplements setDefaultParagraphs in insettabular, as
> described in bug 1953. However, the paragraph merging problem described
there
> is not fixed (this is a different problem, independent from
> setDefault
Juergen Spitzmueller wrote:
> The attached patch reimplements setDefaultParagraphs in insettabular, as
> described in bug 1953.
I'm talking about forceDefaultParagraphs all the time, of course.
Jürgen
26 matches
Mail list logo
