Re: [patch] fix math parser bug

2006-11-11 Thread Georg Baum
Am Montag, 6. November 2006 14:49 schrieb Jean-Marc Lasgouttes: > Well, my fixes in this area were not mainly this point, and I _seem_ > to remember that I did that only because it looked nicer. So I think > indeed that we should revert this. I did this in 1.4 and trunk. Joost, could you please c

Re: [patch] fix math parser bug

2006-11-06 Thread Enrico Forestieri
On Mon, Nov 06, 2006 at 04:26:01PM +0100, Herbert Voss wrote: > Enrico Forestieri schrieb: > > >> And the > >> fact that LyX will eat the other braces if you read the file, and then the > >> inner ones if you save it and read it again. > > > > Nope. That will only occur if the size of the nucleu

Re: [patch] fix math parser bug

2006-11-06 Thread Enrico Forestieri
On Mon, Nov 06, 2006 at 04:25:33PM +0100, Georg Baum wrote: > - do something that you want to undo (e.g. cut). The cursor must be in a > brace inset that will not be restored after undo because of the removal of > superflous brace insets. > - undo > > Now you will either get an assert, or a warni

Re: [patch] fix math parser bug

2006-11-06 Thread Herbert Voss
Enrico Forestieri schrieb: >> And the >> fact that LyX will eat the other braces if you read the file, and then the >> inner ones if you save it and read it again. > > Nope. That will only occur if the size of the nucleus is 1, but then it > doesn't matter as latex macros don't need braces around

Re: [patch] fix math parser bug

2006-11-06 Thread Georg Baum
Enrico Forestieri wrote: > Nope. That will only occur if the size of the nucleus is 1, but then it > doesn't matter as latex macros don't need braces around a single token > argument. Yes, you are right, I mixed that up. >> This will also create undo/redo problems, since undo/redo in math goes >

Re: [patch] fix math parser bug

2006-11-06 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: >> Well, my fixes in this area were not mainly this point, and I >> _seem_ to remember that I did that only because it looked nicer. So >> I think indeed that we should revert this. Enrico> I am curious to know if reverting this wil

Re: [patch] fix math parser bug

2006-11-06 Thread Enrico Forestieri
On Mon, Nov 06, 2006 at 02:49:29PM +0100, Jean-Marc Lasgouttes wrote: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> Enrico Forestieri wrote: > >> On Mon, Nov 06, 2006 at 12:17:53PM +0100, Jean-Marc Lasgouttes > >> wrote: > >>> Would it be a big problem (esthetics aside) to

Re: [patch] fix math parser bug

2006-11-06 Thread Enrico Forestieri
On Mon, Nov 06, 2006 at 01:37:56PM +0100, Georg Baum wrote: > Enrico Forestieri wrote: > > > I beg your pardon, but what's wrong with writing {\xxx{aa}}^2 > > if you want to preserve the braces? See attached file. > > The fact that old files that previously worked did not work anymore. You have

Re: [patch] fix math parser bug

2006-11-06 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Enrico Forestieri wrote: >> On Mon, Nov 06, 2006 at 12:17:53PM +0100, Jean-Marc Lasgouttes >> wrote: >>> Would it be a big problem (esthetics aside) to always leave the >>> braces alone? I do not like behaviour that is not predictable.

Re: [patch] fix math parser bug

2006-11-06 Thread Georg Baum
Enrico Forestieri wrote: > On Mon, Nov 06, 2006 at 12:17:53PM +0100, Jean-Marc Lasgouttes wrote: > >> Would it be a big problem (esthetics aside) to always leave the braces >> alone? I do not like behaviour that is not predictable. No, it would not be a problem. The only drawback are the visible

Re: [patch] fix math parser bug

2006-11-06 Thread Enrico Forestieri
On Mon, Nov 06, 2006 at 12:17:53PM +0100, Jean-Marc Lasgouttes wrote: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> Jean-Marc Lasgouttes wrote: > >>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > >> > Georg> I don't think that that will work. What does work for me

Re: [patch] fix math parser bug

2006-11-06 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> Georg> I don't think that that will work. What does work for me is to Georg> test the previous inset: If it is unknown, do not remove the Georg> b

Re: [patch] fix math parser bug

2006-11-06 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> I don't think that that will work. What does work for me is to > Georg> test the previous inset: If it is unknown, do not remove the > Georg> braces. > > And what about \xxx{aa}{bb}^2 I

Re: [patch] fix math parser bug

2006-11-06 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I don't think that that will work. What does work for me is to Georg> test the previous inset: If it is unknown, do not remove the Georg> braces. And what about \xxx{aa}{bb}^2 It seems difficult to find a good solution, actually. J

Re: [patch] fix math parser bug

2006-11-06 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> A colleague of mine discovered a math parser bug that was > Georg> introduced in 1.4. The attached test file works fine in 1.3 but > Georg> produces a LaTeX error in 1.4. The reason is sp

Re: [patch] fix math parser bug

2006-11-06 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> A colleague of mine discovered a math parser bug that was Georg> introduced in 1.4. The attached test file works fine in 1.3 but Georg> produces a LaTeX error in 1.4. The reason is special treatment Georg> of things like {}_0 that was