Re: [patch] fix inInset crash

2005-02-14 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Am Freitag, 11. Februar 2005 22:19 schrieb Andre Poenitz: >> Please add a FIXME line. Georg> Like the attached? I must admit that I don't really know what Georg> the FIXME should say, because some lines later it is clearly Georg> docu

Re: [patch] fix inInset crash

2005-02-13 Thread Georg Baum
Am Samstag, 12. Februar 2005 18:29 schrieb Andre Poenitz: > Having the string 'FIXME' there is just fine. That's what I am used to > grep for. Ok, this is in now. Georg

Re: [patch] fix inInset crash

2005-02-12 Thread Andre Poenitz
On Sat, Feb 12, 2005 at 05:43:47PM +0100, Georg Baum wrote: > Am Freitag, 11. Februar 2005 22:19 schrieb Andre Poenitz: > > Please add a FIXME line. > > Like the attached? I must admit that I don't really know what the FIXME > should say, Having the string 'FIXME' there is just fine. That's what

Re: [patch] fix inInset crash

2005-02-12 Thread Georg Baum
Am Freitag, 11. Februar 2005 22:19 schrieb Andre Poenitz: > Please add a FIXME line. Like the attached? I must admit that I don't really know what the FIXME should say, because some lines later it is clearly documented that this part of the code is broken: #ifdef WITH_WARNINGS #warning replace

Re: [patch] fix inInset crash

2005-02-12 Thread Andre Poenitz
On Thu, Feb 10, 2005 at 09:16:52PM +0100, Georg Baum wrote: > Wether we'll get rid of this or not, this fixes a crash in the meantime. Please add a FIXME line. Andre'

Re: [patch] fix inInset crash

2005-02-11 Thread Georg Baum
Juergen Spitzmueller wrote: > Georg Baum wrote: >> Wether we'll get rid of this or not, this fixes a crash in the meantime. >> >> Committing now. > > Note that this breaks the display of caption labels _inside_ floats! ??? I did only prevent dereferencing a NULL-pointer, so that can't break any

Re: [patch] fix inInset crash

2005-02-11 Thread Georg Baum
[second try, the first one got lost] Juergen Spitzmueller wrote: > Georg Baum wrote: >> Wether we'll get rid of this or not, this fixes a crash in the meantime. >> >> Committing now. > > Note that this breaks the display of caption labels _inside_ floats! ??? I did only prevent dereferencing a

Re: [patch] fix inInset crash

2005-02-11 Thread Juergen Spitzmueller
Georg Baum wrote: > > Note that this breaks the display of caption labels _inside_ floats! > > ??? > > I did only prevent dereferencing a NULL-pointer, so that can't break > anything. If caption labels inside floats are broken now, they were broken > before. And I don't wonder that they are. Look a

Re: [patch] fix inInset crash

2005-02-11 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I did only prevent dereferencing a NULL-pointer, so that can't Georg> break anything. If caption labels inside floats are broken now, Georg> they were broken before. And I don't wonder that they are. Look Georg> at the comments at that

Re: [patch] fix inInset crash

2005-02-11 Thread Georg Baum
[third try via email, gmane does not like me today] Juergen Spitzmueller wrote: > Georg Baum wrote: >> Wether we'll get rid of this or not, this fixes a crash in the meantime. >> >> Committing now. > > Note that this breaks the display of caption labels _inside_ floats! ??? I did only prevent

Re: [patch] fix inInset crash

2005-02-10 Thread Juergen Spitzmueller
Georg Baum wrote: > Wether we'll get rid of this or not, this fixes a crash in the meantime. > > Committing now. Note that this breaks the display of caption labels _inside_ floats! Regards, Jürgen