On Saturday 24 October 2009 21:53:38 Alex Fernandez wrote:
> It was just a quick fix not to pass it to every method, but we are
> probably better off with a local variable.
Right.
> An object would be a good
> compromise if things grow too complicated.
I agree.
> Alex.
--
José Abílio
On Sat, Oct 24, 2009 at 3:07 AM, Uwe Stöhr wrote:
>>> +exts = [] #list of extensions for which we're checking
>>
>> Why are you making exts a global variable? It should be local, there is
>> no
>> need to pollute the global name space. :-)
>
> This change was proposed by the Alex Fernandez and I
>> +exts = [] #list of extensions for which we're checking
>
> Why are you making exts a global variable? It should be local, there is no
> need to pollute the global name space. :-)
This change was proposed by the Alex Fernandez and I only trusted another Python expert ;-). I
reverted this cha
On 10/23/2009 05:11 AM, José Matos wrote:
def main(argv):
progname = argv[0]
-
-exts = [] #list of extensions for which we're checking
targext = "LyXconv" #extension for target directory
opts, args = getopt.getopt(sys.argv[1:], "e:t:")
for o, v in opts:
@@ -60,27 +
On Friday 23 October 2009 01:53:52 Uwe Stöhr wrote:
> -- ext_copy.py (revision 31691)
> +++ ext_copy.py (working copy)
> @@ -5,7 +5,7 @@
> # This file is part of LyX, the document processor.
> # Licence details can be found in the file COPYING.
>
> -# author Richard Heck
> +# author Richard Hec
rgheck schrieb:
First, create_dir should return a boolean, telling us whether the
creation succeeded. Otherwise, you try to copy the file after a failure.
I implemented this accordingly.
I know I originally wrote this (copying something someone else did), but
maybe we should have more explic
On Thursday 22 October 2009 12:59:57 rgheck wrote:
> instead:
> return copy_all(from_dir, to_dir, exts)
> Then LyX will know if we fail.
I agree with Richard, if the copy process fails LyX should know.
> rh
--
José Abílio
On 10/21/2009 11:12 PM, Uwe Stöhr wrote:
> This looks like it should work, but I haven't tested it. I don't
have anything at the moment that > would use the new functionality.
The functionality is needed to be able to use external converters like
Alex's eLyXer script. I therefore wait for Alex
> This looks like it should work, but I haven't tested it. I don't have anything at the moment that
> would use the new functionality.
The functionality is needed to be able to use external converters like Alex's eLyXer script. I
therefore wait for Alex's test result before applying.
> That s
On 10/21/2009 08:48 PM, Uwe Stöhr wrote:
The attached patch for branch (and also trunk) fixes
http://www.lyx.org/trac/ticket/6234.
Alex and Richard, can you please test and report if it works also for
you.
This looks like it should work, but I haven't tested it. I don't have
anything at the
10 matches
Mail list logo
