Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-30 Thread Dov Feldstern
Stefan Schimanski wrote: Extended it a bit: Index: src/DocIterator.h === --- src/DocIterator.h(Revision 18580) +++ src/DocIterator.h(Arbeitskopie) @@ -233,19 +233,42 @@ private: /** - * When the cursor position is i,

Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-30 Thread Stefan Schimanski
Extended it a bit: Index: src/DocIterator.h === --- src/DocIterator.h (Revision 18580) +++ src/DocIterator.h (Arbeitskopie) @@ -233,19 +233,42 @@ private: /** -* When the cursor position is i, is the cursor after

Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-30 Thread Dov Feldstern
Stefan Schimanski wrote: So moving forward (pos+1) but setting the boundary to true will not register a movement; and staying at the same position, but changing the boundary back to false, *will* appear to move. Is this correct? The other way round: boundary=true => behind the char pos-1. b

Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-30 Thread Stefan Schimanski
P.S. Stefan, just to make sure I really do understand: what I hadn't understood until now is "so how does just setting the boundary, without changing the position, make the cursor move?". I think now I get it: when the cursor drawing is done, it looks at the boundary: if the boundary is set

Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-30 Thread Dov Feldstern
Stefan Schimanski wrote: Please take care with those changes. Such a +1 can change and break a lot. In this I am pretty sure that a character is skipped when going over a newline. I added a special case for the RTL boundary for this line. Okay, I think I understand (how many times have I s

Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-30 Thread Stefan Schimanski
(for http://bugzilla.lyx.org/show_bug.cgi?id=3754) Index: src/Text2.cpp === --- src/Text2.cpp (revision 18569) +++ src/Text2.cpp (working copy) @@ -1031,7 +1031,7 @@ if (cur.pos() != cur.lastpos()) {

Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-29 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Attached is the patch against the new version of Stefan's patch. Stefan, can you please see if it makes sense? I don't really fully understand it, I tried various permutations and this one seems to work, and doesn't appear to break anything else.

Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-29 Thread Stefan Schimanski
Will look tomorrow. Stefan Am 29.05.2007 um 22:56 schrieb Dov Feldstern: Dov Feldstern wrote: Dov Feldstern wrote: Stefan Schimanski wrote: Am 27.05.2007 um 02:27 schrieb Dov Feldstern: Stefan --- now that you're an expert on cursor movement and boundary and all, do you think you could

Re: [patch] Cursor movement at RTL-LTR boundary

2007-05-29 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Stefan Schimanski wrote: Am 27.05.2007 um 02:27 schrieb Dov Feldstern: Stefan --- now that you're an expert on cursor movement and boundary and all, do you think you could tackle a small remaining problem with bidi cursor movement, which I think is