Re: [patch] Bug 2067

2005-10-14 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Georg Baum wrote: >> Ping! We need to do something about this. I attach the patch again >> (ageinst current CVS). Juergen> It fixes the two bugs I am aware of. Georg, go ahead and apply it, then. JMarc

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-14 Thread Juergen Spitzmueller
Georg Baum wrote: > Ping! We need to do something about this. I attach the patch again (ageinst > current CVS). It fixes the two bugs I am aware of. Jürgen

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-14 Thread Georg Baum
Georg Baum wrote: > Am Mittwoch, 5. Oktober 2005 23:22 schrieb Georg Baum: >> Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller: > >> > Did you also notice that if you insert the array which your fix in >> math_parser >> > addresses at [1], save and reload, that the last \hline has va

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-08 Thread Georg Baum
Am Mittwoch, 5. Oktober 2005 23:22 schrieb Georg Baum: > Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller: > > Did you also notice that if you insert the array which your fix in > math_parser > > addresses at [1], save and reload, that the last \hline has vanished? > > Almost: It d

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-05 Thread Georg Baum
Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller: > Georg Baum wrote: > > Yes, although my first thought was wrong. Actually the patch is almost > > right, but it fails if you have a row with extra space (\\[2mm]). > > Although there is no GUI for the latter and it is not documented, w

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Andre Poenitz
On Mon, Oct 03, 2005 at 09:56:09AM +0200, Juergen Spitzmueller wrote: > Does this look sensible? > > Jürgen > > P.S.: the context of the changes: > > void MathGridInset::write(WriteStream & os) const > { > [...] > string const s = verboseHLine(rowinfo_[nrows()].lines_); > if (!s.empt

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Juergen Spitzmueller
Georg Baum wrote: > Yes, although my first thought was wrong. Actually the patch is almost > right, but it fails if you have a row with extra space (\\[2mm]). > Although there is no GUI for the latter and it is not documented, we > should get this right. OK. > I am working on this now (unfortunat

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 14:53 schrieb Juergen Spitzmueller: > Georg Baum wrote: > > Unfortunately not :-( I changed the math parser some time ago to ignore > > the last row if it is empty (see delEmptyLastRow). This is needed for > > arrays with hlines after the last row. > > If something has t

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Juergen Spitzmueller
Georg Baum wrote: > Unfortunately not :-( I changed the math parser some time ago to ignore > the last row if it is empty (see delEmptyLastRow). This is needed for > arrays with hlines after the last row. > If something has to be changed, then in the math parser (e.g. one could > only ignore the em

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 09:56 schrieb Juergen Spitzmueller: > This is a separate bug (# 2067 now). The bug is actually not in undo, but in > MathGridInset::write. This means that a matrix with several empty rows is > also exported to LaTeX incorrectly, because the end-of-line command was n