Re: [Updated Patch 2] One BufferView per Buffer

2007-08-13 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > Your patch is very big (size wise) and I am afraid that at least to me | > that muddles a bit what is happening in it, and it really is tiresome | > to read such huge patches. | | Which is exactly the reason why I sugg

Re: [Updated Patch 2] One BufferView per Buffer

2007-08-13 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > Your patch is very big (size wise) and I am afraid that at least to me | > that muddles a bit what is happening in it, and it really is tiresome | > to read such huge patches. | | Which is exactly the reason why I sugg

Re: [Updated Patch 2] One BufferView per Buffer

2007-08-13 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > Your patch is very big (size wise) and I am afraid that at least to me | > that muddles a bit what is happening in it, and it really is tiresome | > to read such huge patches. | | Which is exactly the reason why I suggested to read the svn diff in

Re: [Updated Patch 2] One BufferView per Buffer

2007-08-13 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdel. | | Index: buffer_funcs.cpp | === | --- buffer_funcs.cpp (revision 19485) | +++ buffer_funcs.cpp (working copy) | @@ -614,4 +616,25 @@ | } |

Re: [Updated Patch 2] One BufferView per Buffer

2007-08-13 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > Your patch is very big (size wise) and I am afraid that at least to me > that muddles a bit what is happening in it, and it really is tiresome > to read such huge patches. Probably seeing the synthetic svn log (that has to be written for the commi

Re: [Updated Patch 2] One BufferView per Buffer

2007-08-13 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdel. | | Index: buffer_funcs.cpp | === | --- buffer_funcs.cpp (revision 19485) | +++ buffer_funcs.cpp (working copy) | @@ -614,4 +616,25 @@ | } | } | | + | +void loadChildD

Re: [Updated Patch 2] One BufferView per Buffer

2007-08-13 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> I reluctantly removed this change from the patch. I wasted two hours >> because of this even if I strongly believe this is useless. I am not >> willing to split the patch even more. So take it as it is or forget >> about it. > > I forgot to revert a