Re: [Patch] fixing tabular paste

2005-05-12 Thread Martin Vermeer
On Thu, 2005-05-12 at 12:04, Angus Leeming wrote: > Martin Vermeer wrote: > > > On Wed, May 11, 2005 at 07:10:36PM +0300, Martin Vermeer wrote: > >> See attached. It fixes at least the menu cut/copy - paste multi-cell > >> within a tabular. > >> > >> OK to commit? > >> > >> - Martin > > > > New

Re: [Patch] fixing tabular paste

2005-05-12 Thread Angus Leeming
Martin Vermeer wrote: >> > Ah... thanks. BTW this thing in insettext.h >> > >> > InsetText(InsetText const &); >> > >> > looks like a copy constructor... but in a funny place. Is it? I use it >> > here as such. Is any destructor needed, or is the standard one enough? >> >> It's a copy constructo

Re: [Patch] fixing tabular paste

2005-05-12 Thread Martin Vermeer
On Thu, 2005-05-12 at 12:33, Angus Leeming wrote: > Martin Vermeer wrote: ... > > Ah... thanks. BTW this thing in insettext.h > > > > InsetText(InsetText const &); > > > > looks like a copy constructor... but in a funny place. Is it? I use it > > here as such. Is any destructor needed, or is th

Re: [Patch] fixing tabular paste

2005-05-12 Thread Angus Leeming
Martin Vermeer wrote: >> Rather than: >> boost::shared_ptr inset; >> inset.reset(new InsetText(*paste_tabular->getCellInset(r1, c1))); >> >> Do this: >> boost::shared_ptr const inset( >> new InsetText(*paste_tabular->getCellInset(r1, c1))); > > Ah... thanks. BTW this thing in

Re: [Patch] fixing tabular paste

2005-05-12 Thread Martin Vermeer
On Thu, 2005-05-12 at 12:04, Angus Leeming wrote: > Martin Vermeer wrote: > > > On Wed, May 11, 2005 at 07:10:36PM +0300, Martin Vermeer wrote: > >> See attached. It fixes at least the menu cut/copy - paste multi-cell > >> within a tabular. > >> > >> OK to commit? > >> > >> - Martin > > > > New

Re: [Patch] fixing tabular paste

2005-05-12 Thread Angus Leeming
Martin Vermeer wrote: > On Wed, May 11, 2005 at 07:10:36PM +0300, Martin Vermeer wrote: >> See attached. It fixes at least the menu cut/copy - paste multi-cell >> within a tabular. >> >> OK to commit? >> >> - Martin > > New and improved... shared pointers are funny things. > > - Martin Rather

Re: [Patch] fixing tabular paste

2005-05-11 Thread Martin Vermeer
On Wed, May 11, 2005 at 07:10:36PM +0300, Martin Vermeer wrote: > See attached. It fixes at least the menu cut/copy - paste multi-cell > within a tabular. > > OK to commit? > > - Martin New and improved... shared pointers are funny things. - Martin Index: insettabular.C ===