Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-08 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sun, Jun 04, 2006 at 09:38:01PM +0200, Abdelrazak Younes wrote: Angus Leeming wrote: In src/frontends/gtk/WorkAreaFactory.C you introduce a new static global variable. By the way, I have always believed that, in C++, the keyword static in this case is to say that this v

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-07 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Jun 05, 2006 at 06:51:52PM +0200, Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > | Angus Leeming wrote: | > | > In src/frontends/gtk/WorkAreaFactory.C you introduce a new static | > | > global variable. | >

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-07 Thread Andre Poenitz
On Mon, Jun 05, 2006 at 06:51:52PM +0200, Lars Gullik Bjønnes wrote: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > | Angus Leeming wrote: > | > In src/frontends/gtk/WorkAreaFactory.C you introduce a new static > | > global variable. > | > | By the way, I have always believed that, in C++, t

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-07 Thread Andre Poenitz
On Sun, Jun 04, 2006 at 09:38:01PM +0200, Abdelrazak Younes wrote: > Angus Leeming wrote: > > > >In src/frontends/gtk/WorkAreaFactory.C you introduce a new static global > >variable. > > By the way, I have always believed that, in C++, the keyword static in > this case is to say that this variab

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-06 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | -class GWorkArea : public WorkArea, public sigc::trackable { | +class GWorkArea : public WorkArea, public Clipboard, public | sigc::trackable { Why inherit? It's a temporary measure that remove the clipboard oriented me

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-06 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Angus Leeming wrote: | > In src/frontends/gtk/WorkAreaFactory.C you introduce a new static | > global variable. | | By the way, I have always believed that, in C++, the keyword static in | this case is to say that this

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-05 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | >| By the way, I have always believed that, in C++, | >| the keyword static in this case is to say that | >| this variable is _not_ global but reserved to | >| this file. This

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-05 Thread Angus Leeming
Lars Gullik Bjønnes wrote > Abdelrazak Younes <[EMAIL PROTECTED]> writes: >| By the way, I have always believed that, in C++, >| the keyword static in this case is to say that >| this variable is _not_ global but reserved to >| this file. This is different for a static variable >| inside a function

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-05 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Angus Leeming wrote: | > In src/frontends/gtk/WorkAreaFactory.C you introduce a new static | > global variable. | | By the way, I have always believed that, in C++, the keyword static in | this case is to say that this variable is _not_ global but r

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-05 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Index: src/frontends/gtk/GWorkArea.h | === | --- src/frontends/gtk/GWorkArea.h (revision 13992) | +++ src/frontends/gtk/GWorkArea.h (working copy) | @@ -15,6 +15,7 @@ | #include

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-05 Thread Angus Leeming
Abdelrazak Younes wrote > Angus Leeming wrote: >> >> What's the point of posting broken code and asking >> for a review if you don't want to hear the comments? > Sorry Angus I didn't meant to hurt you. You don't. > I appreciate your comments but I just want to > go step by step on this last poi

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-04 Thread Peter Kümmel
Abdelrazak Younes wrote: > I will check the documentation on scoped_ptr and I will remove the > scoped_ptr on Clipboard. But ultimately, the job of destruction should > be left to the frontends. scoped_ptr is like auto_ptr, boost docs: The scoped_ptr template is a simple solution for simple needs

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-04 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes wrote Angus Leeming wrote: I'm nervous about your comment to Bo about the Sconscript having a circlar qt4->frontends->qt4 dependency. We avoid such dependencies by use of a factory method to generate concrete instances of classes whose interface is defin

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-04 Thread Angus Leeming
Abdelrazak Younes wrote > Angus Leeming wrote: >> I'm nervous about your comment to Bo about the Sconscript >> having a circlar qt4->frontends->qt4 dependency. We avoid such >> dependencies by use of a factory method to generate concrete >> instances of classes whose interface is defined in src/fr

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-04 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hello, Here is my big clipbard and workarea cleanup patch. I have worked a lot on this one so please don't tell me it can't go in because of missing full split-up of other frontends. This patch should not remove anything from them and I expect others to do the work if

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-04 Thread Angus Leeming
Abdelrazak Younes wrote: >Angus Leeming wrote: >> In src/frontends/gtk/WorkAreaFactory.C you >> introduce a new static global variable. > By the way, I have always believed that, in C++, the > keyword static in this case is to say that this > variable is _not_ global but reserved to this file.

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-04 Thread Abdelrazak Younes
Angus Leeming wrote: In src/frontends/gtk/WorkAreaFactory.C you introduce a new static global variable. By the way, I have always believed that, in C++, the keyword static in this case is to say that this variable is _not_ global but reserved to this file. This is different for a static var

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-04 Thread Abdelrazak Younes
Angus Leeming wrote: I'm nervous about your comment to Bo about the Sconscript having a circlar qt4->frontends->qt4 dependency. We avoid such dependencies by use of a factory method to generate concrete instances of classes whose interface is defined in src/frontends. All subsequent use is throug

Re: [Patch] Workarea/Clipboard splitup and Qt4 support

2006-06-04 Thread Angus Leeming
The http://news.gmane.org/gmane.editors.lyx.devel interface is "down for maintenance", so I'm posting this from my email account; sorry to break the thread. If you CC leeming AT lyx.org in any reply, it'll help me not break the thread any further. Angus I'm nervous about your comment to Bo abo