Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Edwin Leuven
Abdelrazak Younes wrote: Edwin Leuven wrote: other changes i see: 1. before the patch selecting with the mouse down was ill behaved because after reaching the end of the document the cursor would move to the beginning etc 2. tabbing now works in tables (move to next cell) and didn't before

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Abdelrazak Younes
Edwin Leuven wrote: other changes i see: 1. before the patch selecting with the mouse down was ill behaved because after reaching the end of the document the cursor would move to the beginning etc 2. tabbing now works in tables (move to next cell) and didn't before I have some difficulties

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Abdelrazak Younes
Edwin Leuven wrote: selecting with the mousing and letting it scroll down results in the messages below. behavior is good though (no anomalies): can't compare cursor and anchor in different insets p: inset: 0x1e96d20 idx: 5 par: 0 pos: 1 q: inset: 0x1eade68 idx: 6 par: 0 pos: 0 I don't see t

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: And furthermore it get rid of a bug that I noticed sometimes with cursor drawing. Namely that the trace of the former cursor remains after you move it. other changes i see: 1. before the patch selecting with the mouse down was ill behaved because

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes wrote: It is not that useful but it is cleaner code wise. Since the beginning of my qt4 port I wondered why we needed to save the "no cursor" region and restore it. With this patch I finally got rid of it by drawing the cursor after the work-area and only

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Angus Leeming
Abdelrazak Younes wrote: It is not that useful but it is cleaner code wise. Since the beginning of my qt4 port I wondered why we needed to save the "no cursor" region and restore it. With this patch I finally got rid of it by drawing the cursor after the work-area and only if it is needed. Mm

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Edwin Leuven
Abdelrazak Younes wrote: And furthermore it get rid of a bug that I noticed sometimes with cursor drawing. Namely that the trace of the former cursor remains after you move it. other changes i see: 1. before the patch selecting with the mouse down was ill behaved because after reaching the e

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Abdelrazak Younes wrote: Hello, I would like to put this in but I touched a tiny bit the other frontends. Any objection? Abdelrazak> As there is none, I am going to commit. Since you are c

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Abdelrazak Younes wrote: >> Hello, >> >> I would like to put this in but I touched a tiny bit the other >> frontends. Any objection? Abdelrazak> As there is none, I am going to commit. Since you are complaining: wha

Re: [Patch] Qt4 cursor handling simplification

2006-06-02 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hello, I would like to put this in but I touched a tiny bit the other frontends. Any objection? As there is none, I am going to commit. Thanks, Abdel.

Re: [Patch] Qt4 cursor handling simplification

2006-06-01 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > I would like to put this in but I touched a tiny bit the other > frontends. Any objection? Hi, Abdel. Perhaps you might ping John Levon (levon () movementarian ! org>), the architect of the Qt frontend. He might have something illuminating to say b