Re: [Patch] Concept Checks - code improvements

2004-11-20 Thread Andre Poenitz
On Wed, Nov 17, 2004 at 12:03:10PM +0100, Lars Gullik Bjønnes wrote: > And it is good practise and make us follow and adhere to the > requirements put down in the standard. What's wrong in paragraphlist_fwd? If "#include "paragraph.h" is really needed, it could as well be dropped and the whole t

Re: [Patch] Concept Checks - code improvements

2004-11-17 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> The only thing to consider is that currently the concept Lars> checking is turned on with --enable-debug (default on), but we Lars> might want a separate flag for this --enable-concept-checks. But Lars> unless somebody really wa

Re: [Patch] Concept Checks - code improvements

2004-11-17 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> And it is good practise and make us follow and adhere to the | Lars> requirements put down in the standard. > | That's good. There is a 10% penalty in disk size, but that's O

Re: [Patch] Concept Checks - code improvements

2004-11-17 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> And it is good practise and make us follow and adhere to the Lars> requirements put down in the standard. That's good. There is a 10% penalty in disk size, but that's OK. JMarc

Re: [Patch] Concept Checks - code improvements

2004-11-17 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> I had forgotten that gcc does not turn on concept checks by | Lars> defalt, so I did that for builds where --enable-debug is on. > | Lars> This showed a few problems, but mos

Re: [Patch] Concept Checks - code improvements

2004-11-17 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I had forgotten that gcc does not turn on concept checks by Lars> defalt, so I did that for builds where --enable-debug is on. Lars> This showed a few problems, but mostly we are in _very_ good Lars> shape. Lars> I think we sh

Re: [Patch] Concept Checks - code improvements

2004-11-16 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | I have not checked qt and gtk yet, but will do that as well. | (but I don't expect the same problems there as with xforms.) And gtk seems to be even worse since libsigc fails a lot of checks... not good. I wonder who to beat up... -- Lgb