Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, May 31, 2007 at 10:08:18PM +0200, Lars Gullik Bjønnes wrote: | > Richard Heck <[EMAIL PROTECTED]> writes: | > | > | Andre Poenitz wrote: | > | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: | > | > | > | >>> I tried to do someth

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 10:08:18PM +0200, Lars Gullik Bjønnes wrote: > Richard Heck <[EMAIL PROTECTED]> writes: > > | Andre Poenitz wrote: > | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > | > > | >>> I tried to do something like this so I didn't have the same code in two > | >

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 04:02:42PM -0400, Richard Heck wrote: > Andre Poenitz wrote: > >On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > > > >>>I tried to do something like this so I didn't have the same code in two > >>>places: > >>>QModelIndex & QCitationDialog::getSelectedIndex(

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 04:01:32PM -0400, Richard Heck wrote: > Peter Kümmel wrote: > >Richard Heck wrote: > > > >>I tried to do something like this so I didn't have the same code in two > >>places: > >>QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { > >> QModelIndexList const sel

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Lars Gullik Bjønnes
Richard Heck <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: | > | >>> I tried to do something like this so I didn't have the same code in two | >>> places: | >>> QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { | >

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Richard Heck
Andre Poenitz wrote: On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: I tried to do something like this so I didn't have the same code in two places: QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { QModelIndexList const selIdx = availableLV->selectionMode

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Richard Heck
Peter Kümmel wrote: Richard Heck wrote: I tried to do something like this so I didn't have the same code in two places: QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { QModelIndexList const selIdx = availableLV->selectionModel()->selectedIndexes(); if (selIdx.em

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > > I tried to do something like this so I didn't have the same code in two > > places: > > QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { > > QModelIndexList const selIdx = > > availableLV->selectionModel()->se

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Peter Kümmel
Richard Heck wrote: > > Still seeking comment on this patch, or permission to commit. > > = > > The attached patch addresses these bugs > http://bugzilla.lyx.org/show_bug.cgi?id=3741 > http://bugzilla.lyx.org/show_bug.cgi?id=3756 > in a way that is compatible with earlier discussion with A