Jean-Marc Lasgouttes wrote:
>Ben, it seems to me that you sent a patch, but I lost it. Could you
>re-send?
>
Here it is.
I'd appreciate it if people on strange platforms could test it out and
report any problems to me, thanks. I think this one should resolve the
compile problems we had on Sola
> "Ben" == Ben Stanley <[EMAIL PROTECTED]> writes:
Ben> Thanks for the reference - I think it shows the _POSIX_C_SOURCE
Ben> macro is the right thing to do to get the correct prototype.
Ben, it seems to me that you sent a patch, but I lost it. Could you
re-send?
JMarc
On Tue, Dec 11, 2001 at 04:23:00PM +0100, Jean-Marc Lasgouttes wrote:
> Is it possible to do a reintepret_cast which would work always?
C-style casts are sometimes the bigger stick...
> Something like
> if (reinterpret_cast(mm) == reinterpret_cast(MAP_FAILED))
> or is C++ stupid enough to reje
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Ben> So
Lars> what kind of patch are you looking for? Some autoconf magic to |
Lars> Ben> somehow detect a bad type for MAP_FAILED and to deal with
Lars> it | Ben> regardless o
> "Ben" == Ben Stanley <[EMAIL PROTECTED]> writes:
Ben> Please refresh my memory... on this platform, MAP_FAILED is
Ben> defined to be (-1L)?
Yes. I meant to make that clear, but forgot.
Ben> With the _POSIX_C_SOURCE define, we should get void* from mmap
Ben> and others... so it is trying
Jean-Marc Lasgouttes wrote:
>>"Ben" == Ben Stanley <[EMAIL PROTECTED]> writes:
>>
>
>Ben> Jean-Marc, Can you please check if the #define _POSIX_C_SOURCE
>Ben> 199506L
>
>Ben> modification would fix this problem on compaq?
>
>It does not work.
>
Please refresh my memory... on this platfo
> "Ben" == Ben Stanley <[EMAIL PROTECTED]> writes:
Ben> Jean-Marc, Can you please check if the #define _POSIX_C_SOURCE
Ben> 199506L
Ben> modification would fix this problem on compaq?
It does not work. For reference, here is the relevant part of
sys/mman.h:
#if ( defined(_POSIX_C_SOURCE)
Jean-Marc,
Can you please check if the
#define _POSIX_C_SOURCE 199506L
modification would fix this problem on compaq?
I'd also appreciate seeing the standards(5) man page from that platform.
Ben.
Jean-Marc Lasgouttes wrote:
>Compilation of 1.2.0cvs with compaq cxx dies with:
>
>cxx: Error: ..
On Fri, Dec 07, 2001 at 09:29:38AM +1100, Ben Stanley wrote:
> The Solaris headers can be told to give us a POSIX compliant definition
> of munmap by doing
> #define _POSIX_C_SOURCE 199506L
> before
> #include
>
> This seems to be fairly standard - see
[...]
>
> So, I think that the _POSIX_C_S
Lars Gullik Bjønnes wrote:
>"Kayvan A. Sylvan" <[EMAIL PROTECTED]> writes:
>
>| On Thu, Dec 06, 2001 at 08:39:47AM +0100, Lars Gullik Bjønnes wrote:
>
>>>Ben Stanley <[EMAIL PROTECTED]> writes:
>>>
>>>| Please let me know if the attached patch fixes this problem.
>>>
>>>| I also tried to fix the
> "Kayvan" == Kayvan A Sylvan <[EMAIL PROTECTED]> writes:
Kayvan> On Thu, Dec 06, 2001 at 08:39:47AM +0100, Lars Gullik Bjønnes
Kayvan> wrote:
>> Ben Stanley <[EMAIL PROTECTED]> writes:
>>
>> | Please let me know if the attached patch fixes this problem.
>> >
>> | I also tried to fix the Sol
On Thu, Dec 06, 2001 at 08:39:47AM +0100, Lars Gullik Bjønnes wrote:
> Ben Stanley <[EMAIL PROTECTED]> writes:
>
> | Please let me know if the attached patch fixes this problem.
> >
> | I also tried to fix the Solaris compile problem - Kayvan, could you
> | please test it?
>
> I am pretty sure t
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> RETURN VALUES
Jean-Marc> Upon successful completion, the mmap() function returns
Jean-Marc> the address at which the mapping was placed. Otherwise,
Jean-Marc> mmap() returns (caddr_t)-1 and sets errno to indicate
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> I am pretty sure that this is not how we are going to solve this
Lars> problem.
Lars> What I need to know is how this is _supposed_ to be done on cxx,
Lars> and then we can find the correct fix.
Well, mmap() returns a void *
Please let me know if the attached patch fixes this problem.
I also tried to fix the Solaris compile problem - Kayvan, could you
please test it?
I still need to get the proper DepTable patch out. The patch that is
currently in 1.2 is b0rken.
Ben.
Jean-Marc Lasgouttes wrote:
>>"Ben" == B
> "Ben" == Ben Stanley <[EMAIL PROTECTED]> writes:
Ben> This is a version of the mmap patch which applies to cvs HEAD.
Compilation of 1.2.0cvs with compaq cxx dies with:
cxx: Error: ../../../lyx-devel/src/support/lyxsum.C, line 43: operand types
are incompatible ("void *" and "lon
Lars Gullik Bjønnes wrote:
>I think you should submit the complete patch again.
>
Complete patch attached.
process_block does lead to a significant improvement.
Warm cache
ben [11:26:45]
/share/install/linux/extras/lyx/lyx-HEAD/lyx-devel/src/support/tests $
time crccheck.do_crc /share/mp3/ba
Lars Gullik Bjønnes wrote:
>Ben Stanley <[EMAIL PROTECTED]> writes:
>
>| +char *beg = static_cast(mm);
>| +char *end = beg + info.st_size;
>| +
>| +unsigned long result = do_crc(beg,end);
>
>Did you check the speed difference between this and crc.process_block?
18 matches
Mail list logo
