Re: [PATCH] do not use stat() in DepTable

2017-03-11 Thread Enrico Forestieri
On Sat, Mar 11, 2017 at 08:36:08PM +0100, Jean-Marc Lasgouttes wrote: > Le 11/03/2017 à 19:21, Enrico Forestieri a écrit : > > I think that a problem could arise only if the file is a symlink. > > In this case, stat() resolves it and returns information about the > > pointed-to file. It is not very

Re: [PATCH] do not use stat() in DepTable

2017-03-11 Thread Jean-Marc Lasgouttes
Le 11/03/2017 à 19:21, Enrico Forestieri a écrit : I think that a problem could arise only if the file is a symlink. In this case, stat() resolves it and returns information about the pointed-to file. It is not very clear what QFileInfo::lastModified() does. Skimming the docs, it maybe does the s

Re: [PATCH] do not use stat() in DepTable

2017-03-11 Thread Enrico Forestieri
On Fri, Mar 10, 2017 at 11:28:45AM +0100, Jean-Marc Lasgouttes wrote: > Hello, > > The attached patch looks straightforward to me, but since this is a > sensitive area in terms of portability, I would like some people to take a > quick look at it. I think that a problem could arise only if the f