Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > By the way, we can also have a MERGE_LINE option along AS_STR_INSET... Yes. JMarc

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> I am not sure that it looks good after all. For ToC, textString is >> certainly not supposed to output multiple lines... >> > That's why I limited it to the first line? OK, sorry. JMarc

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Abdelrazak Younes
On 26/09/2008 17:41, Jean-Marc Lasgouttes wrote: Jean-Marc Lasgouttes<[EMAIL PROTECTED]> writes: Abdelrazak Younes<[EMAIL PROTECTED]> writes: I think of plaintext as 'verbose export' and textString as 'compact export'. OK, next iteration. This looks good. You mi

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Abdelrazak Younes
On 26/09/2008 17:41, Jean-Marc Lasgouttes wrote: Jean-Marc Lasgouttes<[EMAIL PROTECTED]> writes: Abdelrazak Younes<[EMAIL PROTECTED]> writes: I think of plaintext as 'verbose export' and textString as 'compact export'. OK, next iteration. This looks good. You mi

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Jean-Marc Lasgouttes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: >>> I think of plaintext as 'verbose export' and textString as 'compact export'. >>> >> OK, next iteration. > > This looks good. You might want to look at InsetFlex::textString too. I am not sure t

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> I think of plaintext as 'verbose export' and textString as 'compact export'. >> > OK, next iteration. This looks good. You might want to look at InsetFlex::textString too. JMarc

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Abdelrazak Younes
On 26/09/2008 16:42, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: Because you want to get rid of addToToc() and let the decision be made in textString()? IMO textString() is just a helper method that is useful for toc but could be also used for other purpose (ex:

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Because you want to get rid of addToToc() and let the decision be made > in textString()? IMO textString() is just a helper method that is > useful for toc but could be also used for other purpose (ex: > tooltips). And yes, optional should overload it

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Abdelrazak Younes
On 26/09/2008 15:58, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: There may be insets (think footnotes) that rely on not appearing there. Then InsetFootnote just have to overload the method. I think the rule is more that most insettext should not

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> There may be insets (think footnotes) that rely on not appearing there. > > Then InsetFootnote just have to overload the method. I think the rule is more that most insettext should not appear in toc (think optional arguments too). And your patch wil

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Abdelrazak Younes
On 26/09/2008 15:40, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: Is the attached what you have in mind? Updated patch to cope with carriage return. Yes, except that I am not 100% sure that it should go to InsetText. Well, the goal would be

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Is the attached what you have in mind? > > Updated patch to cope with carriage return. Yes, except that I am not 100% sure that it should go to InsetText. There may be insets (think footnotes) that rely on not appearing there. JMarc

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Abdelrazak Younes
On 26/09/2008 15:22, Abdelrazak Younes wrote: On 26/09/2008 14:20, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: On 24/09/2008 05:43, Jack M. Lyon wrote: It would also be nice to display each index entry in its entirety rather than just a snippet . . . This is im

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Abdelrazak Younes
On 26/09/2008 14:20, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: On 24/09/2008 05:43, Jack M. Lyon wrote: It would also be nice to display each index entry in its entirety rather than just a snippet . . . This is implemented in the attached patc

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Abdelrazak Younes
On 26/09/2008 14:20, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: On 24/09/2008 05:43, Jack M. Lyon wrote: It would also be nice to display each index entry in its entirety rather than just a snippet . . . This is implemented in the attached patc

Re: [PATCH] display full index text in Navigator (was Re: Display of index in the Outline window--sorted alphabetically)

2008-09-26 Thread José Matos
On Friday 26 September 2008 10:51:44 Abdelrazak Younes wrote: > This is implemented in the attached patch. I think this is safe for rc3 > Jose but this is your call. > > Abdel. Let us wait here. The patch is OK for after rc3 (with Jean-Marc's remark). -- José Abílio

Re: [PATCH] display full index text in Navigator

2008-09-26 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > On 24/09/2008 05:43, Jack M. Lyon wrote: >> It would also be nice to display each index entry in its entirety rather >> than just a snippet . . . >> > > This is implemented in the attached patch. I think this is safe for > rc3 Jose but this is you