Re: [PATCH] QDocument (A4 specials)

2003-02-12 Thread Juergen Spitzmueller
Kuba Ober wrote: > - let the core do all package-depedent checks > - the core then returns a functionality set (flags) to the frontend > - the frontend diasables/enables widgets per functionality set (bitmapped > flags) and also indicated invalid entries per some more flags I don't know if this wi

Re: [PATCH] QDocument (A4 specials)

2003-02-12 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > I will apply your three patches (is that right?), Yes. a4-3.diff, papersize.diff and bug 844.diff. Thanks. > but it would be > nice in 1.4 to clean this up in buffer.C too. Agreed. I think you can apply the patches so that everything works. Then we can start clean

Re: [PATCH] QDocument (A4 specials)

2003-02-12 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> I think this is more transparent, as the user sees "Aha, this Juergen> is not possible now". But once the logic is handled by the Juergen> frontend, the core code is not needed anymore I think (unless Juergen> you think t

Re: [PATCH] QDocument (A4 specials)

2003-02-12 Thread Kuba Ober
> > Juergen> I think we should decide if we want the logic in the core or > > Juergen> in the frontends. I'd vote for the frontend simply because of > > Juergen> transparency to the users (disabling/enabling widgets etc.) > > Juergen> and because the frontends have different means to handle the > >

Re: [PATCH] QDocument (A4 specials)

2003-02-11 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Juergen> I think we should decide if we want the logic in the core or > Juergen> in the frontends. I'd vote for the frontend simply because of > Juergen> transparency to the users (disabling/enabling widgets etc.) > Juergen> and because the frontends have different mea

Re: [PATCH] QDocument (A4 specials)

2003-02-11 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> I think we should decide if we want the logic in the core or Juergen> in the frontends. I'd vote for the frontend simply because of Juergen> transparency to the users (disabling/enabling widgets etc.) Juergen> and because

Re: [PATCH] QDocument (A4 specials)

2003-02-11 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > | Which would look a like the attached patch, which solves bug 844 > | frontend-wise. With this, BufferParams::setPaperStuff and thus the > | papersize/papersize2 distinction could go I think (but this is rather > | your area). This means that the clever stuff moved fro

Re: [PATCH] QDocument (A4 specials)

2003-02-10 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Juergen Spitzmueller) writes: | Juergen Spitzmueller wrote: | > apart from that it is an xforms specific problem. The qt | > frontend resets packages to none when the paperformat changes to anything | > different than A4. XForms should do that too | | Which would look a like th

Re: [PATCH] QDocument (A4 specials)

2003-02-10 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > apart from that it is an xforms specific problem. The qt > frontend resets packages to none when the paperformat changes to anything > different than A4. XForms should do that too Which would look a like the attached patch, which solves bug 844 frontend-wise. With th

Re: [PATCH] QDocument (A4 specials)

2003-02-10 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Juergen> I think this can go into 1.3 too (the patch is against > Juergen> 1.3.1cvs, but it should also apply to HEAD). > > Does this fix the problems in bug 844? The situation is rather ugly > currently and I would like a global fix. No, I was not aware of that. It f

Re: [PATCH] QDocument (A4 specials)

2003-02-10 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Fixes a small bug in QDocumentDialog: the A4 extra packages Juergen> should also be shown if default papersize is A4 and default Juergen> chosen, furthermore only in portrait mode. This is the case Juergen> in Xforms and

Re: [PATCH] QDocument (A4 specials)

2003-02-09 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Yes, you're right. Try this. Arghh, I have accidentally snipped the changes in *.h. Thanks, Jürgen. Index: src/frontends/qt2/ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/ChangeLog,v retri

Re: [PATCH] QDocument (A4 specials)

2003-02-09 Thread Juergen Spitzmueller
John Levon wrote: > > Fixes a small bug in QDocumentDialog: the A4 extra packages should also > > be shown if default papersize is A4 and default chosen, furthermore only > > in portrait mode. This is the case in Xforms and previous LyX versions. > > Seems like that change_adaptor will no longer be

Re: [PATCH] QDocument (A4 specials)

2003-02-08 Thread John Levon
On Sun, Feb 09, 2003 at 03:16:05AM +0100, Juergen Spitzmueller wrote: > Fixes a small bug in QDocumentDialog: the A4 extra packages should also be > shown if default papersize is A4 and default chosen, furthermore only in > portrait mode. This is the case in Xforms and previous LyX versions. Se