On 10/8/20 9:28 AM, Jean-Marc Lasgouttes wrote:
> Le 07/10/2020 à 17:31, Richard Kimberly Heck a écrit :
>> On 10/7/20 10:31 AM, Yuriy Skalko wrote:
>>> And the last patch based on the static analyzers output.
>>
>> diff --git a/src/Author.cpp b/src/Author.cpp
>> index 9a2dc1ea43..b4cf9fd97b 100644
Le 07/10/2020 à 17:31, Richard Kimberly Heck a écrit :
On 10/7/20 10:31 AM, Yuriy Skalko wrote:
And the last patch based on the static analyzers output.
diff --git a/src/Author.cpp b/src/Author.cpp
index 9a2dc1ea43..b4cf9fd97b 100644
--- a/src/Author.cpp
+++ b/src/Author.cpp
@@ -31,8 +31,8 @@
On 10/7/20 3:09 PM, Yuriy Skalko wrote:
>> I like that. I have to admit that I gave up checking that the loops were
>> equivalent roughly at the first third of the patch :)
>>
>> Is it done by hand or with some tool?
> I used combination of clang-tidy and hands.
>
>
>> There are also in the Qt par
> I like that. I have to admit that I gave up checking that the loops were
> equivalent roughly at the first third of the patch :)
>
> Is it done by hand or with some tool?
I used combination of clang-tidy and hands.
> There are also in the Qt part things like:
>
> +
On 10/7/20 10:31 AM, Yuriy Skalko wrote:
> And the last patch based on the static analyzers output.
diff --git a/src/Author.cpp b/src/Author.cpp
index 9a2dc1ea43..b4cf9fd97b 100644
--- a/src/Author.cpp
+++ b/src/Author.cpp
@@ -31,8 +31,8 @@ static int computeHash(docstring const & name,
st
Le 07/10/2020 à 16:31, Yuriy Skalko a écrit :
And the last patch based on the static analyzers output.
I like that. I have to admit that I gave up checking that the loops were
equivalent roughly at the first third of the patch :)
Is it done by hand or with some tool?
A few remarks, first on
