Re: [PATCH] InsetNewline

2003-03-13 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Ho no. Could it be that you have found the root of the existance of the > little square? Damn! Now _that_ is a HUGE regression. A minute of silence please. Thank you. Alfredo

Re: [PATCH] InsetNewline

2003-03-12 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Mar 12, 2003 at 06:02:34PM +0100, Lars Gullik Bjønnes wrote: | > You use one wrong construct: "new InsetNewline()" | > that should be: "new InsetNewline" (remvoe the parenthesis) | | I like the latter more, too, but I think in this case it is e

Re: [PATCH] InsetNewline

2003-03-12 Thread Andre Poenitz
On Wed, Mar 12, 2003 at 06:02:34PM +0100, Lars Gullik Bjønnes wrote: > You use one wrong construct: "new InsetNewline()" > that should be: "new InsetNewline" (remvoe the parenthesis) I like the latter more, too, but I think in this case it is equivalent (assuming that it compiles at all) Andre'

Re: [PATCH] InsetNewline

2003-03-12 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Mar 12, 2003 at 05:31:49PM +, John Levon wrote: | | > Forget it, I can't get the patch to work at all anyway, it segfaults | > looking for an inset at the end of a par that contains a newline. Lord | > knows why. | | Heh, good one META_I

Re: [PATCH] InsetNewline

2003-03-12 Thread Alfredo Braunstein
John Levon wrote: > We have bogus getChar()s in a number of places. Can we at least start > making some console noise for them ? Ho no. Could it be that you have found the root of the existance of the little square? Damn! Alfredo

Re: [PATCH] InsetNewline

2003-03-12 Thread John Levon
On Wed, Mar 12, 2003 at 06:51:20PM +0100, Lars Gullik Bj?nnes wrote: > | Heh, good one META_INSET is now == 0. Guess what we return on a > | bogus getChar(pos) ... > > Move to 1? I'm building that now. john

Re: [PATCH] InsetNewline

2003-03-12 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Mar 12, 2003 at 05:31:49PM +, John Levon wrote: | | > Forget it, I can't get the patch to work at all anyway, it segfaults | > looking for an inset at the end of a par that contains a newline. Lord | > knows why. | | Heh, good one META_I

Re: [PATCH] InsetNewline

2003-03-12 Thread John Levon
On Wed, Mar 12, 2003 at 05:31:49PM +, John Levon wrote: > Forget it, I can't get the patch to work at all anyway, it segfaults > looking for an inset at the end of a par that contains a newline. Lord > knows why. Heh, good one META_INSET is now == 0. Guess what we return on a bogus getC

Re: [PATCH] InsetNewline

2003-03-12 Thread John Levon
On Wed, Mar 12, 2003 at 05:21:13PM +, John Levon wrote: > I did ??? Where ? Forget it, I can't get the patch to work at all anyway, it segfaults looking for an inset at the end of a par that contains a newline. Lord knows why. john

Re: [PATCH] InsetNewline

2003-03-12 Thread John Levon
On Wed, Mar 12, 2003 at 06:02:34PM +0100, Lars Gullik Bj?nnes wrote: > Also it seems that you removed all backward comp wrt reading old > files, if you do this, then lyx2lyx should be updated at the same > time. I did ??? Where ? john

Re: [PATCH] InsetNewline

2003-03-12 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | Probably won't build but it's a sketch ... comments ? | | Note we could make it have a really big width but this would actually | just complicated rowBreakPoint() and we'd *still* have to special case | it anyway. It removes a lot of lines good. You use

Re: [PATCH] InsetNewline

2003-03-12 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Wed, Mar 12, 2003 at 04:39:04PM +, John Levon wrote: >> > You can probably make InsetNewline::noFontChange() return true, >> and > font setting will be closed and reopened later. >> >> OK John> Actually I don't really understand

Re: [PATCH] InsetNewline

2003-03-12 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Wed, Mar 12, 2003 at 05:28:20PM +0100, Jean-Marc Lasgouttes John> wrote: >> You can probably make InsetNewline::noFontChange() return true, and >> font setting will be closed and reopened later. John> OK >> The test for style.newlin

Re: [PATCH] InsetNewline

2003-03-12 Thread John Levon
On Wed, Mar 12, 2003 at 04:39:04PM +, John Levon wrote: > > You can probably make InsetNewline::noFontChange() return true, and > > font setting will be closed and reopened later. > > OK Actually I don't really understand all this TYPEWRITER_FAMILY stuff.. > john

Re: [PATCH] InsetNewline

2003-03-12 Thread John Levon
On Wed, Mar 12, 2003 at 05:28:20PM +0100, Jean-Marc Lasgouttes wrote: > You can probably make InsetNewline::noFontChange() return true, and > font setting will be closed and reopened later. OK > The test for style.newline_allowed can probably be moved to the inset > too. Erm how ? john

Re: [PATCH] InsetNewline

2003-03-12 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> Probably won't build but it's a sketch ... comments ? John> Note we could make it have a really big width but this would John> actually just complicated rowBreakPoint() and we'd *still* have John> to special case it anyway. Concerning

Re: [PATCH] InsetNewline

2003-03-12 Thread Andre Poenitz
On Wed, Mar 12, 2003 at 04:17:39PM +, John Levon wrote: > Probably won't build but it's a sketch ... comments ? I have not applied it, but that's certainly the right direction. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, eithe