Re: [PATCH] Fixing cursors in multiview mode

2007-05-24 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: The only simple solution I can think of right now is to emit a signal in the Inset destructor that we can connect to the CursorSlice. The CursorSlice will then invalidate itself. Here is what I came up with. In principle this sh

Re: [PATCH] Fixing cursors in multiview mode

2007-05-23 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > The only simple solution I can think of right now is to emit a signal in > > the Inset destructor that we can connect to the CursorSlice. The > > CursorSlice will then invalidate itself. > > Here is what I came up with. In principle this should s

Re: [PATCH] Fixing cursors in multiview mode

2007-05-23 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Stefan Schimanski wrote: The attached patch fixes that. It should fix also a number of other situation where cursor may be invalidated. I had to add a test in Cursor:

Re: [PATCH] Fixing cursors in multiview mode

2007-05-23 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Stefan Schimanski wrote: The attached patch fixes that. It should fix also a number of other situation where cursor may be invalidated. I had to add a test in Cursor::fixIfBroken() for the cas

Re: [PATCH] Fixing cursors in multiview mode

2007-05-23 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Stefan Schimanski wrote: >>> The attached patch fixes that. It should fix also a number of >>> other situation where cursor may be invalidated. I had to add a >>> test in Cursor::fixIfBroken() for the case were we are

Re: [PATCH] Fixing cursors in multiview mode (was Re: Warning Question)

2007-05-23 Thread Abdelrazak Younes
Stefan Schimanski wrote: The attached patch fixes that. It should fix also a number of other situation where cursor may be invalidated. I had to add a test in Cursor::fixIfBroken() for the case were we are not inside an Inset but in the main Text. Nice! Testing it for a few minutes now. Looks

Re: [PATCH] Fixing cursors in multiview mode (was Re: Warning Question)

2007-05-23 Thread Stefan Schimanski
The attached patch fixes that. It should fix also a number of other situation where cursor may be invalidated. I had to add a test in Cursor::fixIfBroken() for the case were we are not inside an Inset but in the main Text. Nice! Testing it for a few minutes now. Looks fine. Couldn't cause a