Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Jean-Marc Lasgouttes
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes: Richard> And there's a similar question about the citation-insert code Richard> that precedes. It'd be quite easy at this point to do the Richard> enhancement mentioned there, but there's a question about the Richard> format of the comman

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Hey, that's not fair! I was busy preparing a garden party for 80 people! To be fair, some of the messages in the thread are familiar to me... Richard> Indeed, how to define the optional argument was one of the Richard> major issues. (The other option was a new LFUN.)

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Jean-Marc Lasgouttes
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes: Richard> I'm pretty sure he did: Richard> http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg120884.html. >[PATCH] Child TOC Crash, Again >Richard Heck >Sat, 16 Jun 2007 10:14:39 -0700 Hey, that's not fair! I was busy preparing a ga

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Richard Heck
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Note that Richard asked for comment at the time. Sure, but he did not point to this particular "feature" :) I'm pretty sure he did: http://www.mail-archive.com/lyx-devel@lists

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak> Note that Richard asked for comment at the time. Sure, but he did not point to this particular "feature" :) IIRC he asked what was the correct syntax for argument but nobody (including me) answered him. Abdelrazak> I agree and I already started to t

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Abdelrazak Younes
José Matos wrote: On Tuesday 10 July 2007 15:56:04 Jean-Marc Lasgouttes wrote: Abdelrazak> But for the time being, let's please get 1.5.0 out. Sure. In this respect, your patch is OK. +1 Done, thanks.

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread José Matos
On Tuesday 10 July 2007 15:56:04 Jean-Marc Lasgouttes wrote: > Abdelrazak> But for the time being, let's please get 1.5.0 out. > > Sure. In this respect, your patch is OK. +1 -- José Abílio

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Why is the lyx_view_ needed? Abdelrazak> LFUN_BUFFER_CHILD_OPEN uses LyXView::loadLyXFile() because Abdelrazak> of outline, tabbar, etc. OK. Abdelrazak> Note that Richard asked for comment at the time. Sure, but he did not

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> This patch revert part of the code changed in revision Abdelrazak> 18825. This is needed because there is no lyx_view_ when Abdelrazak> exporting at the command-line. Why is the lyx_view_ need

Re: [PATCH] Fix crash exporting a multi-part document at the command-line

2007-07-10 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> This patch revert part of the code changed in revision Abdelrazak> 18825. This is needed because there is no lyx_view_ when Abdelrazak> exporting at the command-line. Why is the lyx_view_ needed? Also, I know it does