Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-27 Thread Jürgen Spitzmüller
Stephan Witt wrote: > > Jürgen > > Yes, it works. Thanks. I'll commit the advanced version, then. Jürgen

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-27 Thread Stephan Witt
Am 27.07.2013 um 10:19 schrieb Jürgen Spitzmüller : > Enrico Forestieri wrote: >> I have no strong preference, so I will let you select that one you >> deem more appropriate. The second one is consistent with the behavior >> in lyx 2.0.x, while the first one seems to better reflect the actual >> l

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-27 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > I have no strong preference, so I will let you select that one you > > deem more appropriate. The second one is consistent with the behavior > > in lyx 2.0.x, while the first one seems to better reflect the actual > > locale settings. > > Do

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-27 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > I have no strong preference, so I will let you select that one you > deem more appropriate. The second one is consistent with the behavior > in lyx 2.0.x, while the first one seems to better reflect the actual > locale settings. Does the attached patch work with Qt5? Jü

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-26 Thread Enrico Forestieri
On Fri, Jul 19, 2013 at 10:32:27PM +0200, Stephan Witt wrote: > I think another move would be better: the internal representation of > numeric values as strings is not a good idea. The code looks much > nicer when making the font_sizes an array of double values. > > Of course making the font_size

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-19 Thread Stephan Witt
Am 20.07.2013 um 07:57 schrieb Kornel Benko : > Am Freitag, 19. Juli 2013 um 22:32:27, schrieb Stephan Witt > > Am 10.07.2013 um 17:09 schrieb Enrico Forestieri : > > > > > In setLocale() (GuiApplication.cpp), we call setlocale(LC_NUMERIC, "C"). > > > This means that all locale-aware functions u

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-19 Thread Kornel Benko
Am Freitag, 19. Juli 2013 um 22:32:27, schrieb Stephan Witt > Am 10.07.2013 um 17:09 schrieb Enrico Forestieri : > > > In setLocale() (GuiApplication.cpp), we call setlocale(LC_NUMERIC, "C"). > > This means that all locale-aware functions use '.' as the decimal separator. > > However, even if Qt5

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-19 Thread Stephan Witt
Am 10.07.2013 um 17:09 schrieb Enrico Forestieri : > In setLocale() (GuiApplication.cpp), we call setlocale(LC_NUMERIC, "C"). > This means that all locale-aware functions use '.' as the decimal separator. > However, even if Qt5 respects this setting (for example, QString::toDouble() > does the rig

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-10 Thread Enrico Forestieri
On Wed, Jul 10, 2013 at 05:43:25PM +0200, Jean-Marc Lasgouttes wrote: > 10/07/2013 17:09, Enrico Forestieri: > >In setLocale() (GuiApplication.cpp), we call setlocale(LC_NUMERIC, "C"). > >This means that all locale-aware functions use '.' as the decimal separator. > >However, even if Qt5 respects t

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-10 Thread Jean-Marc Lasgouttes
10/07/2013 17:09, Enrico Forestieri: In setLocale() (GuiApplication.cpp), we call setlocale(LC_NUMERIC, "C"). This means that all locale-aware functions use '.' as the decimal separator. However, even if Qt5 respects this setting (for example, QString::toDouble() does the right thing), QLocale::s