Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-20 Thread José Matos
On Sunday 19 October 2008 21:26:14 Jean-Marc Lasgouttes wrote: > I think they are OK. +1 > JMarc -- José Abílio

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-20 Thread Richard Heck
Jean-Marc Lasgouttes wrote: rgheck <[EMAIL PROTECTED]> writes: Any further views about these patches? Or are these OK to go now? I think they are OK. OK. I'll put this stuff in later today. rh

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-19 Thread Jean-Marc Lasgouttes
rgheck <[EMAIL PROTECTED]> writes: > Any further views about these patches? Or are these OK to go now? I think they are OK. JMarc

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-19 Thread rgheck
Any further views about these patches? Or are these OK to go now? I wonder a bit about the size of the patches, and I have to admit that I did not follow closely. Is this still necessary, or rather a feature that could wait a while? Fair questions. Regarding size, most of this patch jus

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-17 Thread rgheck
Jean-Marc Lasgouttes wrote: rgheck <[EMAIL PROTECTED]> writes: First, right now, LFUN_LAYOUT_MODULE_ADD works too well: It allows you to add things you shouldn't be allowed to add, which could lead to LaTeX errors. What is the mechanism in place to detect this case ? Modules can a

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-17 Thread Jean-Marc Lasgouttes
rgheck <[EMAIL PROTECTED]> writes: > First, right now, LFUN_LAYOUT_MODULE_ADD works too well: It allows you > to add things you shouldn't be allowed to add, which could lead to > LaTeX errors. What is the mechanism in place to detect this case ? > The way the GUI works at the moment, changes to t

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-17 Thread José Matos
On Friday 17 October 2008 05:36:59 Abdelrazak Younes wrote: > Looks sane to me. It looks sane to me as well but in this case I would like to hear other developers opinion. > Abdel. -- José Abílio

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-16 Thread Abdelrazak Younes
On 16/10/2008 22:41, rgheck wrote: Andre Poenitz wrote: On Thu, Oct 16, 2008 at 03:23:10PM -0400, rgheck wrote: + +if (!foundOne) +return false; + +return true; +} "return foundOne;" Thanks. Copy-paste I wonder a bit about the size of the patches, and I have to admit

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-16 Thread rgheck
Andre Poenitz wrote: On Thu, Oct 16, 2008 at 03:23:10PM -0400, rgheck wrote: + + if (!foundOne) + return false; + + return true; +} "return foundOne;" Thanks. Copy-paste I wonder a bit about the size of the patches, and I have to admit that I did n

Re: [PATCH] Fix LFUN_LAYOUT_MODULE_ADD

2008-10-16 Thread Andre Poenitz
On Thu, Oct 16, 2008 at 03:23:10PM -0400, rgheck wrote: > + > + if (!foundOne) > + return false; > + > + return true; > +} "return foundOne;" I wonder a bit about the size of the patches, and I have to admit that I did not follow closely. Is this still necessary, or rather a