"Michael Gerz" <[EMAIL PROTECTED]> writes:
| Well, my attempt is to hide as much of the CT logic as possible behind
| class Paragraph. Having a method rather than a helper function makes
| things a bit more clearer to me.
At the expense of higher coupling and less cohesion.
--
Lgb
On Wed, May 24, 2006 at 01:04:20PM +, Angus Leeming wrote:
> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> > Michael> isDeletedText has been changed into a method of class
> > Michael> Paragraph (where it belongs). This is also more OO-like.
>
> > I think Lars prefers to have these kind o
Michael> Hi Jean-Marc,
I do not see why you remove isDeletedText and isInsertedText. These
are typically helper functions and do not need to be methods at
all.
Michael> IIRC, isInsertedText() is not used at all.
Do you know why? It is strange.
I don't know. A lot of complicated things happen
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> Michael> isDeletedText has been changed into a method of class
> Michael> Paragraph (where it belongs). This is also more OO-like.
> I think Lars prefers to have these kind of helper functions outside of
> classes. We tend to have too many methods
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes:
Michael> Hi Jean-Marc,
>> I do not see why you remove isDeletedText and isInsertedText. These
>> are typically helper functions and do not need to be methods at
>> all.
Michael> IIRC, isInsertedText() is not used at all.
Do you know why
Hi Jean-Marc,
I do not see why you remove isDeletedText and isInsertedText. These
are typically helper functions and do not need to be methods at all.
IIRC, isInsertedText() is not used at all.
isDeletedText has been changed into a method of class Paragraph (where it
belongs). This is also m
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes:
Michael> Hi, the attached patch adds trackChanges flags to various
Michael> methods and includes some minor cleanups.
Michael> The overall idea is that whenever you insert or erase text,
Michael> you have to tell the corresponding method
