Re: [PATCH] Bug 3676

2007-08-04 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: >> A static definition in header file is not acceptable. > OK, I can do that. >> However, it sounds much easier to me to move Buffer::fillWithBibKeys to >> frontend_helpers.cpp with the rest. This has no reason to be a buffer >> method. >> > I don't know

Re: [PATCH] Bug 3676

2007-08-03 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Richard Heck <[EMAIL PROTECTED]> writes: Attached is the latest patch addressing this bug. I'm seeking agreement to commit it to trunk, for testing, prior to committing to branch, hopefully for 1.5.2. This has been discussed with Jurgen already. JMarc, or someone e

Re: [PATCH] Bug 3676

2007-08-03 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > Attached is the latest patch addressing this bug. I'm seeking agreement > to commit it to trunk, for testing, prior to committing to branch, > hopefully for 1.5.2. This has been discussed with Jurgen already. JMarc, > or someone else: Does this seem OK? Y

Re: [PATCH] Bug 3676

2007-07-31 Thread Andre Poenitz
On Tue, Jul 31, 2007 at 03:00:34PM -0400, Richard Heck wrote: > Index: src/Buffer.h > === > --- src/Buffer.h (revision 19264) > +++ src/Buffer.h (working copy) > @@ -13,7 +13,11 @@ > #define BUFFER_H > > #include "DocIter

Re: [PATCH] Bug 3676

2007-07-30 Thread Jürgen Spitzmüller
Richard Heck wrote: > OK. I did a good bit of testing earlier and saw no problems, but I > haven't tested it since updating it to current trunk. It's actually less > complex than it seems. The improvement lies in our storing the data for > the individual BibTeX fields in a std::map rather than one