Re: [PATCH] Bug 3633.

2007-05-23 Thread Abdelrazak Younes
Bo Peng wrote: Index: src/insets/InsetInclude.cpp === --- src/insets/InsetInclude.cpp(revision 18451) +++ src/insets/InsetInclude.cpp(working copy) @@ -858,6 +858,22 @@ void InsetInclude::addToToc(TocList & toclist, Buffer

Re: [PATCH] Bug 3633.

2007-05-23 Thread Jean-Marc Lasgouttes
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes: Bo> I see, the problem with InsetInclude is that it does not have any Bo> real paragraph inside so I can not move to this inset from Bo> navigation menu Yes, we would have to expand dociterator to understand insetinclude. Not completely trivia

Re: [PATCH] Bug 3633.

2007-05-22 Thread José Matos
On Tuesday 22 May 2007 8:58:53 pm Bo Peng wrote: > Jose, can I apply the first part of this patch? Yes with the André's remarks. > Bo -- José Abílio

Re: [PATCH] Bug 3633.

2007-05-22 Thread Bo Peng
Being derived from InsetText is not crucial, however, having a working Text * InsetFoo::getText(int index) is. This usually means you need 'some kind of embedded Text somewhere'... I see, the problem with InsetInclude is that it does not have any real paragraph inside so I can not move to th

Re: [PATCH] Bug 3633.

2007-05-22 Thread Andre Poenitz
On Tue, May 22, 2007 at 02:10:04PM -0500, Bo Peng wrote: > >> + if (floatName != string()) > > > > if (!floatName.empty()) > > Thanks Andre, but do you know how to get the pit of an InsetInclude? I am afraid I don't understand the question. In most cases a variable 'pit' is an i

Re: [PATCH] Bug 3633.

2007-05-22 Thread Bo Peng
> + if (floatName != string()) if (!floatName.empty()) Thanks Andre, but do you know how to get the pit of an InsetInclude? Bo + // This *does not* work because pit is not a proper ParConstIterator + // at least pit->id() would cra

Re: [PATCH] Bug 3633.

2007-05-22 Thread Andre Poenitz
On Tue, May 22, 2007 at 10:17:47AM -0500, Bo Peng wrote: > The first part is easy. > > Index: src/MenuBackend.cpp > === > --- src/MenuBackend.cpp (revision 18451) > +++ src/MenuBackend.cpp (working copy) > @@ -734,7 +734,1