Re: [PATCH] Bug 3461

2007-04-19 Thread Richard Heck
So what's the status here? This look OK at this point? The neatest thing to do would have been just to put form_->setGotoRef() in closeEvent(). That's what I tried first, and it didn't work. I can't remember why now. I think it was because closeEvent() doesn't routinely get triggered when the can

Re: [PATCH] Bug 3461

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: Edwin Leuven wrote: Richard Heck wrote: Attached patch addresses 3461. Comments please. if only all bugs were this easy to fix... Indeed. But you know, there are a lot of cheap bugs on bugzilla---or so I'm finding---and I'll bet we could squash dozens if we were so inclin

Re: [PATCH] Bug 3461

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: Actual patch. Richard Index: QRefDialog.C === --- QRefDialog.C(revision 17850) +++ QRefDialog.C(working copy) @@ -33,6

Re: [PATCH] Bug 3461

2007-04-18 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >> Edwin Leuven wrote: >>> Richard Heck wrote: Attached patch addresses 3461. Comments please. >>> if only all bugs were this easy to fix... >> Indeed. > I guess Edwin only meant that the patch was missing Richard ;-) I did eventually figure that

Re: [PATCH] Bug 3461

2007-04-18 Thread Abdelrazak Younes
Richard Heck wrote: Edwin Leuven wrote: Richard Heck wrote: Attached patch addresses 3461. Comments please. if only all bugs were this easy to fix... Indeed. I guess Edwin only meant that the patch was missing Richard ;-) But you know, there are a lot of cheap bugs on bugzilla---or so I'

Re: [PATCH] Bug 3461

2007-04-18 Thread Richard Heck
Edwin Leuven wrote: > Richard Heck wrote: >> Attached patch addresses 3461. Comments please. > if only all bugs were this easy to fix... Indeed. But you know, there are a lot of cheap bugs on bugzilla---or so I'm finding---and I'll bet we could squash dozens if we were so inclined. I'll do some to

Re: [PATCH] Bug 3461

2007-04-18 Thread Edwin Leuven
Richard Heck wrote: Attached patch addresses 3461. Comments please. if only all bugs were this easy to fix...