Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-11 Thread Kornel Benko
Am Freitag, 10. Oktober 2014 um 22:09:30, schrieb Stephan Witt > Am 10.10.2014 um 15:39 schrieb Kornel Benko : > > > Am Freitag, 10. Oktober 2014 um 15:31:33, schrieb Kornel Benko > > > >> Am Freitag, 10. Oktober 2014 um 15:22:20, schrieb Kornel Benko > >> > >>> Am Freitag, 10. Oktober 2014 um

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Stephan Witt
Am 10.10.2014 um 14:07 schrieb Jean-Marc Lasgouttes : > Le 10/10/2014 13:04, Stephan Witt a écrit : >> Cmake patch proposal: Ok to commit? > > What happens if git is not installed or the build is done from tar.gz archive > instead of a git clone? LYX_GIT_COMMIT_HASH is "none" in this case. To

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Stephan Witt
Am 10.10.2014 um 15:39 schrieb Kornel Benko : > Am Freitag, 10. Oktober 2014 um 15:31:33, schrieb Kornel Benko > >> Am Freitag, 10. Oktober 2014 um 15:22:20, schrieb Kornel Benko >> >>> Am Freitag, 10. Oktober 2014 um 13:04:32, schrieb Stephan Witt >>> Am 10.10.2014 um 12:17 schrieb Jea

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Kornel Benko
Am Freitag, 10. Oktober 2014 um 15:31:33, schrieb Kornel Benko > Am Freitag, 10. Oktober 2014 um 15:22:20, schrieb Kornel Benko > > > Am Freitag, 10. Oktober 2014 um 13:04:32, schrieb Stephan Witt > > > > > Am 10.10.2014 um 12:17 schrieb Jean-Marc Lasgouttes : > > > > > > > Le 10/10/2014 07:0

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Kornel Benko
Am Freitag, 10. Oktober 2014 um 15:22:20, schrieb Kornel Benko > Am Freitag, 10. Oktober 2014 um 13:04:32, schrieb Stephan Witt > > > Am 10.10.2014 um 12:17 schrieb Jean-Marc Lasgouttes : > > > > > Le 10/10/2014 07:08, Stephan Witt a écrit : > > >>> I am not sure whether it is worth having it in

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Kornel Benko
Am Freitag, 10. Oktober 2014 um 13:04:32, schrieb Stephan Witt > Am 10.10.2014 um 12:17 schrieb Jean-Marc Lasgouttes : > > > Le 10/10/2014 07:08, Stephan Witt a écrit : > >>> I am not sure whether it is worth having it in the start screen. This is > >>> rather specialized information. > > > > Wha

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Jean-Marc Lasgouttes
Le 10/10/2014 13:04, Stephan Witt a écrit : Cmake patch proposal: Ok to commit? What happens if git is not installed or the build is done from tar.gz archive instead of a git clone? JMarc

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Stephan Witt
Am 10.10.2014 um 12:17 schrieb Jean-Marc Lasgouttes : > Le 10/10/2014 07:08, Stephan Witt a écrit : >>> I am not sure whether it is worth having it in the start screen. This is >>> rather specialized information. > > What about the patch I just commited? > > Note that it needs a cmake counterpa

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Stephan Witt
Am 10.10.2014 um 12:17 schrieb Jean-Marc Lasgouttes : > Le 10/10/2014 07:08, Stephan Witt a écrit : >>> I am not sure whether it is worth having it in the start screen. This is >>> rather specialized information. > > What about the patch I just commited? I'm fine with it. Thanks. I'm ok with th

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Jean-Marc Lasgouttes
Le 10/10/2014 07:08, Stephan Witt a écrit : I am not sure whether it is worth having it in the start screen. This is rather specialized information. What about the patch I just commited? Note that it needs a cmake counterpart, to define the new LYX_GIT_COMMIT_HASH macro. I am also open to ch

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Stephan Witt
Am 10.10.2014 um 10:12 schrieb Jean-Marc Lasgouttes : > Le 10/10/2014 07:08, Stephan Witt a écrit : >> Sorry, I was off-line already yesterday. >> It's in lyx_version_info. GuiAbout::buildinfo() returns it. > > You mean that it is visible only because it is par of the command line? > > JMarc >

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-10 Thread Jean-Marc Lasgouttes
Le 10/10/2014 07:08, Stephan Witt a écrit : Sorry, I was off-line already yesterday. It's in lyx_version_info. GuiAbout::buildinfo() returns it. You mean that it is visible only because it is par of the command line? JMarc

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-09 Thread Stephan Witt
Am 09.10.2014 um 23:07 schrieb Jean-Marc Lasgouttes : > Le 09/10/2014 22:38, Stephan Witt a écrit : >> It ends up in the 4th tab of the About dialog - the build info. > > Sorry if I am a bit dense this evening, but where is the code that makes it > happen? Sorry, I was off-line already yesterda

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-09 Thread Jean-Marc Lasgouttes
Le 09/10/2014 22:38, Stephan Witt a écrit : It ends up in the 4th tab of the About dialog - the build info. Sorry if I am a bit dense this evening, but where is the code that makes it happen? > I've made a little patch to place it into the start screen. > I'm not sure if it's worth to apply.

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-10-09 Thread Stephan Witt
Am 09.10.2014 um 22:22 schrieb Jean-Marc Lasgouttes : > Le 28/08/2014 08:31, Stephan Witt a écrit : >> commit f2aeca65b491f4a2396ec2b8834713e5c156c5ef >> Author: Stephan Witt >> Date: Thu Aug 28 08:30:45 2014 +0200 >> >> pass git commit hash within CPPFLAGS to add it to version info > > S

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-08-30 Thread Jean-Marc Lasgouttes
On 28 août 2014 08:31:13 UTC+02:00, Stephan Witt wrote: >commit f2aeca65b491f4a2396ec2b8834713e5c156c5ef >Author: Stephan Witt >Date: Thu Aug 28 08:30:45 2014 +0200 > >pass git commit hash within CPPFLAGS to add it to version info > >diff --git a/development/LyX-Mac-binary-release.sh >b/dev

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-08-29 Thread Stephan Witt
Am 28.08.2014 um 17:30 schrieb Richard Heck : > On 08/28/2014 02:36 AM, Stephan Witt wrote: >> Am 28.08.2014 um 08:31 schrieb Stephan Witt : >> >>> commit f2aeca65b491f4a2396ec2b8834713e5c156c5ef >>> Author: Stephan Witt >>> Date: Thu Aug 28 08:30:45 2014 +0200 >>> >>>pass git commit hash

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-08-28 Thread Richard Heck
On 08/28/2014 02:36 AM, Stephan Witt wrote: Am 28.08.2014 um 08:31 schrieb Stephan Witt : commit f2aeca65b491f4a2396ec2b8834713e5c156c5ef Author: Stephan Witt Date: Thu Aug 28 08:30:45 2014 +0200 pass git commit hash within CPPFLAGS to add it to version info diff --git a/development/Ly

Re: [LyX/master] pass git commit hash within CPPFLAGS to add it to version info

2014-08-27 Thread Stephan Witt
Am 28.08.2014 um 08:31 schrieb Stephan Witt : > commit f2aeca65b491f4a2396ec2b8834713e5c156c5ef > Author: Stephan Witt > Date: Thu Aug 28 08:30:45 2014 +0200 > >pass git commit hash within CPPFLAGS to add it to version info > > diff --git a/development/LyX-Mac-binary-release.sh > b/devel