Re: [LyX/master] Cache the value of GuiFontMetrics::lbearing().

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 16:44, Richard Kimberly Heck a écrit : I I did not mistype something, the danger is null: we already cache rbearing (and width, ascent and descent) for the same reason. I only added caching of lbearing. The only use of lbearing has been added in the 2.3 development cycle, whence t

Re: [LyX/master] Cache the value of GuiFontMetrics::lbearing().

2019-03-21 Thread Jean-Marc Lasgouttes
Le 21/03/2019 à 00:08, Richard Kimberly Heck a écrit : I can confirm this this helps a lot on windows, at least with the test case that we received. Riki, OK to backport? Yes, thank you. Is there any danger to this, do you think? If so, I could try to produce a 'testing' binary before we move

Re: [LyX/master] Cache the value of GuiFontMetrics::lbearing().

2019-03-20 Thread Richard Kimberly Heck
On 3/20/19 5:14 PM, Jean-Marc Lasgouttes wrote: > Le 20/03/2019 à 11:58, Jean-Marc Lasgouttes a écrit : >> Le 20/03/2019 à 11:46, Jean-Marc Lasgouttes a écrit : >>> commit d3979e798cd9c85041bb5e6158002384a8cddb8c >>> Author: Jean-Marc Lasgouttes >>> Date:   Wed Mar 20 10:56:16 2019 +0100 >>> >>>  

Re: [LyX/master] Cache the value of GuiFontMetrics::lbearing().

2019-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2019 à 11:58, Jean-Marc Lasgouttes a écrit : Le 20/03/2019 à 11:46, Jean-Marc Lasgouttes a écrit : commit d3979e798cd9c85041bb5e6158002384a8cddb8c Author: Jean-Marc Lasgouttes Date:   Wed Mar 20 10:56:16 2019 +0100 Cache the value of GuiFontMetrics::lbearing(). This seems to

Re: [LyX/master] Cache the value of GuiFontMetrics::lbearing().

2019-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2019 à 11:46, Jean-Marc Lasgouttes a écrit : commit d3979e798cd9c85041bb5e6158002384a8cddb8c Author: Jean-Marc Lasgouttes Date: Wed Mar 20 10:56:16 2019 +0100 Cache the value of GuiFontMetrics::lbearing(). This seems to be necessary on windows, where math editing can