Re: [Embedding PATCH] Update graphics dialog when the embedding status is changed.

2007-09-14 Thread Bo Peng
> The attached patch: > Here it is. Bo Index: src/insets/InsetGraphicsParams.h === --- src/insets/InsetGraphicsParams.h (revision 20282) +++ src/insets/InsetGraphicsParams.h (working copy) @@ -17,6 +17,7 @@ #include "graphics/Graphic

Re: [Embedding PATCH] Update graphics dialog when the embedding status is changed.

2007-09-14 Thread Bo Peng
> Sounds like a plan? > The attached patch: 1. Use EmbeddedFile for InsetGraphicsParams::filename. This involves params2string and file format change. 2. Because InsetGraphics now has embedding information, it can be easily updated from the embedding dialog. The inset graphic dialog now has an e

Re: [Embedding PATCH] Update graphics dialog when the embedding status is changed.

2007-09-14 Thread Bo Peng
> Attached is an updated patch, which is even uglier because it tries to > display 'Embedded:/filename' in the graphic dialog when the file is > embedded. As you can imagine, back and forth translations are needed. I am actually waiting for someone to say ' this is way too ugly. Why do not you mer

Re: [Embedding PATCH] Update graphics dialog when the embedding status is changed.

2007-09-13 Thread Bo Peng
> Here is a question for you: Do you want to display true, embedded > filename, or the may-not-exist external filename in the graphics > dialog? The attached patch does the former, but in a ugly way: > Attached is an updated patch, which is even uglier because it tries to display 'Embedded:/filena