Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > I like it, but I can imagine that others wouldn't. Well ... > Small glitch, when you choose None, one of the dialog buttons reads: > ..assign to ' ' ? I have added a specific message for this case, and committed. Jürgen

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Vincent van Ravesteijn
Jürgen Spitzmüller schreef: Vincent van Ravesteijn wrote: > No, it didn't change with the UI. But, I did lose the symmetry. Creating > a new group now needs an extra explicit step (in comparison to 1.6.1 and > the combobox), while deleting a group is still an automatic process. > This somehow fe

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > No, it didn't change with the UI. But, I did lose the symmetry. Creating > a new group now needs an extra explicit step (in comparison to 1.6.1 and > the combobox), while deleting a group is still an automatic process. > This somehow feels uncomfortable. try the att

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > It is nice to have a new group button, but it is less fun that a group > without any images disappears. Would it be an idea to give a warning that a > certain group becomes empty also you will need additional changes to code for removing graphics inset from doc.

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Vincent van Ravesteijn
Jürgen Spitzmüller schreef: Pavel Sanda wrote: > > I think to achieve this (correctly), we will need to store the groups in > > the document params (which is a file format change). > > my view from the very begining. to produce what you want needs to switch > from group to template philosophy.

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > I think to achieve this (correctly), we will need to store the groups in > > > the document params (which is a file format change). > > > > my view from the very begining. to produce what you want needs to switch > > from group to template philos

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > I think to achieve this (correctly), we will need to store the groups in > > the document params (which is a file format change). > > my view from the very begining. to produce what you want needs to switch > from group to template philosophy. But this didn't change with the

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Vincent van Ravesteijn wrote: > > It is nice to have a new group button, but it is less fun that a group > > without any images disappears. Would it be an idea to give a warning > > that a certain group becomes empty and ask the user whether he would > > like to retain t

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > It is nice to have a new group button, but it is less fun that a group > without any images disappears. Would it be an idea to give a warning > that a certain group becomes empty and ask the user whether he would > like to retain the group or whether the group can be

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Vincent van Ravesteijn
Jürgen Spitzmüller schreef: Pavel Sanda wrote: > i wonder why filename->setText(current_filename) & QString current_filename > = filename->text() gymnastics is needed; isn't this done by par.filename = > params_.filename; ? The rationale is: if you change the filename of an existing graphics

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > ok, is par.filename = params_.filename; needed now ? No. Jürgen

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > i wonder why filename->setText(current_filename) & QString current_filename > > = filename->text() gymnastics is needed; isn't this done by par.filename = > > params_.filename; ? > > The rationale is: if you change the filename of an existing grap

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i wonder why filename->setText(current_filename) & QString current_filename > = filename->text() gymnastics is needed; isn't this done by par.filename = > params_.filename; ? The rationale is: if you change the filename of an existing graphics without applying, and then assig

Re: [Cvslog] r28184 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-16 Thread Pavel Sanda
sp...@lyx.org wrote: > Author: spitz > Date: Fri Jan 16 15:54:25 2009 > New Revision: 28184 > > URL: http://www.lyx.org/trac/changeset/28184 > Log: > * GuiGraphics.{cpp,h}: > * GraphicsUi.ui: > - polish UI for graphics groups. > + > + // filename might have been changed > + QSt