Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 12:49, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: The only difference is that I preserve the efficiency ;-) And that you have one of these useless and confusing mutable objects. What about this? That's good. Abdel.

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > The only difference is that I preserve the efficiency ;-) And that you have one of these useless and confusing mutable objects. What about this? JMarc svndiff src/frontends/qt4/GuiParagraph.cpp src/frontends/qt4/GuiParagraph.h Index: src/frontend

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 12:31, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: Hum, I already did that :-) And it seems that the patches are almost equivalent... The only difference is that I preserve the efficiency ;-) Abdel.

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Hum, I already did that :-) And it seems that the patches are almost equivalent... JMarc

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 12:22, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: That is not a question of smartness but of efficiency. At the time I didn't want to trigger to make a full copy of the current parameter set each cursor move. That was not to avoid the dispatch of

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Hum... in decoded abdel mode that means: At the time I didn't want to > make a full copy of the current parameter set for each cursor move. I understood that :) But I doubt that this copy is expensive. JMarc

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > That is not a question of smartness but of efficiency. At the time I > didn't want to trigger to make a full copy of the current parameter > set each cursor move. That was not to avoid the dispatch of an LFUN > which can still be done easily with curr

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 11:59, Abdelrazak Younes wrote: On 29/09/2008 10:53, Jean-Marc Lasgouttes wrote: This is typically a consequence of code that tries to be smart: directly access param at point when we do not have a selection, and avoid to dispatch an lfun. That is not a question of smartness but

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 10:53, Jean-Marc Lasgouttes wrote: [EMAIL PROTECTED] writes: Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5285 . --- lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp (original) +++ lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp Fri Sep 26 23:34:08 2008 @@ -338,6 +338,7

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> I think this chage should be reverted and GuiParagraph should be changed >> to work through LyXFunc. > Is that a question or a request to do it? If the former: I agree, if > the later, not in the immediate future :-) It is mainly a request to think

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 10:53, Jean-Marc Lasgouttes wrote: [EMAIL PROTECTED] writes: Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5285 . --- lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp (original) +++ lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp Fri Sep 26 23:34:08 2008 @@ -338,6 +338,7

Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp

2008-09-29 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] writes: > Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5285 . > --- lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp (original) > +++ lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp Fri Sep 26 23:34:08 > 2008 > @@ -338,6 +338,7 @@ > > bufferview()->updateMetrics()