Re: [Cvslog] r22149 - in /lyx-devel/trunk/src: Buffer.cpp Mover.cpp in...

2007-12-15 Thread Andre Poenitz
On Fri, Dec 14, 2007 at 11:17:35PM +0100, Abdelrazak Younes wrote: > But I see that the check for existence is already there in > FileName::removeFile() (you introduced it right?). Trying to remove a file > that does not exist seems like a waste of time to me. I would bet that whatever system fu

Re: [Cvslog] r22149 - in /lyx-devel/trunk/src: Buffer.cpp Mover.cpp in...

2007-12-14 Thread Enrico Forestieri
On Sat, Dec 15, 2007 at 12:04:36AM +0100, Abdelrazak Younes wrote: > Enrico Forestieri wrote: > > On Fri, Dec 14, 2007 at 11:17:35PM +0100, Abdelrazak Younes wrote: > > >>> This is wrong. Simply try to remove the file without checking for its > >>> existence and then fall through to directly tryi

Re: [Cvslog] r22149 - in /lyx-devel/trunk/src: Buffer.cpp Mover.cpp in...

2007-12-14 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Fri, Dec 14, 2007 at 11:17:35PM +0100, Abdelrazak Younes wrote: This is wrong. Simply try to remove the file without checking for its existence and then fall through to directly trying to rename. In case the file the could not be removed, the rename fails and you ge

Re: [Cvslog] r22149 - in /lyx-devel/trunk/src: Buffer.cpp Mover.cpp in...

2007-12-14 Thread Enrico Forestieri
On Fri, Dec 14, 2007 at 11:17:35PM +0100, Abdelrazak Younes wrote: > Enrico Forestieri wrote: > > On Fri, Dec 14, 2007 at 06:16:28PM -, [EMAIL PROTECTED] wrote: > > > >> Author: younes > >> Date: Fri Dec 14 19:16:25 2007 > >> New Revision: 22149 > >> > >> URL: http://www.lyx.org/trac/changese

Re: [Cvslog] r22149 - in /lyx-devel/trunk/src: Buffer.cpp Mover.cpp in...

2007-12-14 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Fri, Dec 14, 2007 at 06:16:28PM -, [EMAIL PROTECTED] wrote: Author: younes Date: Fri Dec 14 19:16:25 2007 New Revision: 22149 URL: http://www.lyx.org/trac/changeset/22149 Log: The rename() function removed in rev had in fact move() functionality. So we replace

Re: [Cvslog] r22149 - in /lyx-devel/trunk/src: Buffer.cpp Mover.cpp in...

2007-12-14 Thread Enrico Forestieri
On Fri, Dec 14, 2007 at 06:16:28PM -, [EMAIL PROTECTED] wrote: > Author: younes > Date: Fri Dec 14 19:16:25 2007 > New Revision: 22149 > > URL: http://www.lyx.org/trac/changeset/22149 > Log: > The rename() function removed in rev had in fact move() functionality. So we > replace all uses of