RE: Re: feature request

2006-04-09 Thread Leuven, E.
Title: RE: Re: feature request > I had to do that in text.C. Cursor inherits DocIterator so > you can use that. "ParIterator it(cur)" should do the trick. that's what i did, see attached. it get's quite ugly though because selections can be set both forward

RE: Re: feature request

2006-04-08 Thread Leuven, E.
> You're right, it is not a simple check. Should > probably be renamed to "trySimpleLabelUpdate". > Opinion? separate the check and the labelupdate? do updatecounters and updatelabel always coincide? am not the person to answer really

RE: Re: feature request

2006-04-08 Thread Leuven, E.
Title: RE: Re: feature request >> what happens in setCounter(,)? > It is misnamed (should be setLabel, I am working on that). > This would set the bullet depending on the depth of the > current paragraph. i don't understand why anything needs to be 'set' i

RE: Re: feature request

2006-04-08 Thread Leuven, E.
> Use needsUpdateCounters. See text2.C for example. i had a look at it and was wondering about the following case LABEL_ITEMIZE: setCounter(buf, it); return false; what happens in setCounter(,)? if needsUpdateCounters() only *checks* for the type of layo

Re: Re: feature request

2006-04-08 Thread Martin Vermeer
On Sat, Apr 08, 2006 at 07:49:32PM +0200, Leuven, E. wrote: ... > > updateCounters(cur.buffer()); (2x) > > > > Please put a FIXME in here for Abdel (or fix yourself). > > This will be dog slow on Windows. > > can i check whether a paragraph contains a counter (so that > we updateCounters

RE: Re: feature request

2006-04-08 Thread Leuven, E.
> I'm sure you mean // 275 (is the count right?) you're right! > updateCounters(cur.buffer()); (2x) > > Please put a FIXME in here for Abdel (or fix yourself). > This will be dog slow on Windows. can i check whether a paragraph contains a counter (so that we updateCounters only when we n

Re: Re: feature request

2006-04-08 Thread Martin Vermeer
On Sat, Apr 08, 2006 at 05:02:18PM +0200, Leuven, E. wrote: ... > updated patch attached > Content-Description: par4.diff Index: src/lfuns.h === --- src/lfuns.h (revision 13594) +++ src/lfuns.h (working copy) @@ -358,6 +358,9 @@

RE: Re: feature request

2006-04-08 Thread Leuven, E.
Title: RE: Re: feature request sorry wrong file. correct patch here... Index: src/LyXAction.C === --- src/LyXAction.C (revision 13594) +++ src/LyXAction.C (working copy) @@ -353,6 +353,8 @@ { LFUN_MOUSE_RELEASE

RE: Re: feature request

2006-04-08 Thread Leuven, E.
Title: RE: Re: feature request > Better, but perhaps to as J-M says and use > LFUN_PARAGRAPH_MOVE_{UP,DOWN} as well. > Can you have a quick look and see if there are > some nice place to put this in emacs.bind as well? updated patch attached Index: src

RE: Re: feature request

2006-04-08 Thread Leuven, E.
Title: RE: Re: feature request > Can we change the name of the LFUN? done > Note how you stole another commands name. (C-Up) oops like attached? Index: src/LyXAction.C === --- src/LyXAction.C (revision 13594) +